Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test optimization] Update config shape sent as telemetry #4098

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

juan-fernandez
Copy link
Contributor

@juan-fernandez juan-fernandez commented Feb 14, 2025

Motivation

Following runbook in https://github.com/DataDog/system-tests/blob/main/docs/edit/runbook.md#test_config_telemetry_completeness

Corresponding dd-go's PR: [test optimization] AddtestManagementAttemptToFixRetries and isTestManagementEnabled to telemetry

Corresponding dd-trace-js' PR: DataDog/dd-trace-js#5236

Changes

Update telemetry by running

./tests/telemetry_intake/update.sh

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@juan-fernandez juan-fernandez marked this pull request as ready for review February 14, 2025 17:11
@juan-fernandez juan-fernandez requested review from a team as code owners February 14, 2025 17:11
@juan-fernandez juan-fernandez requested review from wantsui and removed request for a team February 14, 2025 17:11
@juan-fernandez juan-fernandez merged commit a2788f3 into main Feb 17, 2025
395 of 410 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/update-telemetry-again branch February 17, 2025 08:34
@iunanua iunanua mentioned this pull request Feb 17, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants