Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NodeJS] skip more failing baggage tests #4021

Merged
merged 2 commits into from
Feb 7, 2025
Merged

[NodeJS] skip more failing baggage tests #4021

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4d8b99
skip failing tests
ida613 Feb 7, 2025
2e28e3a
fix linter error
ida613 Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions tests/parametric/test_headers_baggage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,10 @@ def _assert_valid_baggage(self, test_library):
headers = test_library.dd_make_child_span_and_get_headers([["baggage", "foo=valid"]])
assert "baggage" in headers

@missing_feature(
context.library == "nodejs",
reason="`dd_make_child_span_and_get_headers` calls `dd_extract_headers_and_make_child_span`, which does not work with only baggage",
)
def test_baggage_malformed_headers_D012(self, test_library):
"""Ensure that malformed baggage headers are handled properly. Unable to use get_baggage functions because it does not return anything"""
Test_Headers_Baggage._assert_valid_baggage(self, test_library)
Expand All @@ -210,6 +214,10 @@ def test_baggage_malformed_headers_D012(self, test_library):

assert "baggage" not in headers

@missing_feature(
context.library == "nodejs",
reason="`dd_make_child_span_and_get_headers` calls `dd_extract_headers_and_make_child_span`, which does not work with only baggage",
)
def test_baggage_malformed_headers_D013(self, test_library):
"""Ensure that malformed baggage headers are handled properly. Unable to use get_baggage functions because it does not return anything"""
Test_Headers_Baggage._assert_valid_baggage(self, test_library)
Expand All @@ -219,6 +227,10 @@ def test_baggage_malformed_headers_D013(self, test_library):

assert "baggage" not in headers

@missing_feature(
context.library == "nodejs",
reason="`dd_make_child_span_and_get_headers` calls `dd_extract_headers_and_make_child_span`, which does not work with only baggage",
)
def test_baggage_malformed_headers_D014(self, test_library):
Test_Headers_Baggage._assert_valid_baggage(self, test_library)

Expand All @@ -227,6 +239,10 @@ def test_baggage_malformed_headers_D014(self, test_library):

assert "baggage" not in headers

@missing_feature(
context.library == "nodejs",
reason="`dd_make_child_span_and_get_headers` calls `dd_extract_headers_and_make_child_span`, which does not work with only baggage",
)
def test_baggage_malformed_headers_D015(self, test_library):
Test_Headers_Baggage._assert_valid_baggage(self, test_library)

Expand Down