Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config_norm_rules.json #3793

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Update config_norm_rules.json #3793

merged 3 commits into from
Jan 24, 2025

Conversation

watson
Copy link
Contributor

@watson watson commented Jan 9, 2025

Motivation

Keep things clean. See https://github.com/DataDog/dd-go/pull/164428#issuecomment-2580576784 for details.

Changes

Remove 3 normalization rules that was never used by anybody.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@watson watson requested a review from a team as a code owner January 9, 2025 17:47
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no change ?

@watson
Copy link
Contributor Author

watson commented Jan 23, 2025

Oh, I think something got lost in a rebase. I'll fix and update the PR

Copy link
Contributor Author

watson commented Jan 23, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure is not related

@watson watson merged commit c51da63 into main Jan 24, 2025
432 of 433 checks passed
@watson watson deleted the watson/remove-unused-norm-rules branch January 24, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants