[Debugger] Symdb tests #3761
Merged
[Debugger] Symdb tests #3761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojung
reviewed
Jan 2, 2025
| @@ -275,6 +275,8 @@ tests/: | |||
| Test_Debugger_Probe_Snaphots: irrelevant | |||
| test_debugger_probe_status.py: | |||
| Test_Debugger_Probe_Statuses: irrelevant | |||
| test_debugger_symdb.py: | |||
| Test_Debugger_SymDb: irrelevant | |||
There was a problem hiding this comment.
Why is this irrelevant and not missing feature?
There was a problem hiding this comment.
Hmmm, you're right, I aligned with other definitions for this library.
I will fix it in separate PR.
ojung
approved these changes
Jan 7, 2025
shurivich
force-pushed
the
shurivich/symdb
branch
2 times, most recently
from
f0efcaa to
eb190f1
Compare
shurivich
force-pushed
the
shurivich/symdb
branch
from
eb190f1 to
4da86a3
Compare
shurivich
requested review from
duncanista,
mabdinur,
jandro996,
Mariovido,
mcculls and
cataphract
and removed request for
a team
ojung
reviewed
Jan 20, 2025
cbeauchesne
requested changes
Jan 20, 2025
7 tasks
watson
requested changes
Jan 21, 2025
Co-authored-by: Thomas Watson <[email protected]>
tylfin
reviewed
Jan 21, 2025
cbeauchesne
reviewed
Jan 22, 2025
Co-authored-by: Charles de Beauchesne <[email protected]>
cbeauchesne
approved these changes
Jan 22, 2025
| raw_data = list(interfaces.library.get_data(_SYMBOLS_PATH)) | ||
|
|
||
| for data in raw_data: | ||
| if isinstance(data, dict) and "request" in data: |
There was a problem hiding this comment.
If my not wrong, data is always a dict, and request will always be in data.
watson
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add SymDb system tests
Changes
Add symdb tests.
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present