Skip to content

[java] Add tests for database sources in springboot #3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 21, 2025
Merged

[java] Add tests for database sources in springboot #3742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
25480ab
Add system-tests for taint db values for java
Mariovido Dec 24, 2024
eed2f93
Update test
Mariovido Dec 27, 2024
26abc9d
Merge branch 'main' into mario.vidal/add_db_taint_tests_java
Mariovido Jan 16, 2025
4c8481b
Update version in manifest
Mariovido Jan 16, 2025
ed0d202
Update manifest to be more specific
Mariovido Jan 17, 2025
149ad46
Merge branch 'main' into mario.vidal/add_db_taint_tests_java
Mariovido Jan 17, 2025
9d2f06c
Merge branch 'main' into mario.vidal/add_db_taint_tests_java
Mariovido Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion manifests/java.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,16 @@ tests/:
TestPathParameter:
'*': missing_feature
test_sql_row.py:
TestSqlRow: missing_feature
TestSqlRow:
'*': v1.46.0
akka-http: missing_feature (endpoint not implemented)
jersey-grizzly2: missing_feature (endpoint not implemented)
play: missing_feature (endpoint not implemented)
ratpack: missing_feature (endpoint not implemented)
resteasy-netty3: missing_feature (endpoint not implemented)
spring-boot-3-native: missing_feature (GraalVM. Tracing support only)
vertx3: missing_feature (endpoint not implemented)
vertx4: missing_feature (endpoint not implemented)
test_uri.py:
TestURI:
'*': v1.23.0
Expand Down
2 changes: 1 addition & 1 deletion tests/appsec/iast/source/test_sql_row.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ class TestSqlRow(BaseSourceTest):

endpoint = "/iast/source/sql/test"
source_type = "sql.row.value"
source_names = ["0.username"]
source_names = ["0.username", "USERNAME"]
requests_kwargs = [{"method": "GET"}]
10 changes: 10 additions & 0 deletions ...ava/spring-boot/src/main/java/com/datadoghq/system_tests/springboot/AppSecIastSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import java.util.Collection;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.concurrent.TimeUnit;
import java.util.function.Function;
import java.util.function.Predicate;
Expand Down Expand Up @@ -163,6 +164,15 @@ public ResponseEntity<String> kafkaValue() throws Exception {
return kafka("iast-group-value", "key", "hello value!", record -> Paths.get(record.value()).toString());
}

@GetMapping("/sql/test")
public String sourceSql() {
final List<Map<String, Object>> queryResult = (List<Map<String, Object>>) sql.secureSql("shaquille_oatmeal", "123456");
final String username = (String) queryResult.get(0).get("USERNAME");

sql.insecureSql(username);
return "OK";
}

private ResponseEntity<String> kafka(final String group, final String key, final String value, final KafkaRecordHandler op) throws Exception {
final KafkaConnector connector = new KafkaConnector();
final long timeout = TimeUnit.SECONDS.toMillis(10);
Expand Down
Loading