-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] parametric app improvements #3723
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
223303e
to
f296fa8
Compare
6173f48
to
0d884a9
Compare
755e081
to
dc1c562
Compare
dc1c562
to
e01c48d
Compare
cbeauchesne
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for improving this !!
bouwkast
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dev-x
Improve developer experience
dotnet
Pull requests that update .NET code
run-parametric-scenario
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve the developer experience of modifying, running, and troubleshooting the
parametric
app for .NET.Changes
Newtonsoft.Json
with the built-inSystem.Text.Json
I will do the same with the OpenTelemetry test endpoints (
ApmTestApiOtel.cs
) in a separate PR and then remove theNewtonsoft.Json
reference.Note
While making these changes I found several unrelated bugs when using the .NET tracing library's manual API:
Span.Service = null
after the span is created causes an exception when the span is closed. Working on a fix here:[tracer] fix exception when closing a
Span
with nullServiceName
dd-trace-dotnet#6748SpanCreationSettings.Parent = SpanContext.None
results in a 64-bit trace id even if 128-bit trace id generation is enabled (we generate 128 bits, but the upper 64 bits are truncated somewhere)SpanContextExtractor
that returnsnull
causes an exception. Working on a fix here:[tracing] add null checks when iterating headers in propagators dd-trace-dotnet#6460
Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present