Skip to content

Commit

Permalink
[NodeJS] skip more failing baggage tests (#4021)
Browse files Browse the repository at this point in the history
  • Loading branch information
ida613 authored Feb 7, 2025
1 parent 7d25777 commit 68fb7b7
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions tests/parametric/test_headers_baggage.py
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,10 @@ def _assert_valid_baggage(self, test_library):
headers = test_library.dd_make_child_span_and_get_headers([["baggage", "foo=valid"]])
assert "baggage" in headers

@missing_feature(
context.library == "nodejs",
reason="`dd_make_child_span_and_get_headers` calls `dd_extract_headers_and_make_child_span`, which does not work with only baggage",
)
def test_baggage_malformed_headers_D012(self, test_library):
"""Ensure that malformed baggage headers are handled properly. Unable to use get_baggage functions because it does not return anything"""
Test_Headers_Baggage._assert_valid_baggage(self, test_library)
Expand All @@ -210,6 +214,10 @@ def test_baggage_malformed_headers_D012(self, test_library):

assert "baggage" not in headers

@missing_feature(
context.library == "nodejs",
reason="`dd_make_child_span_and_get_headers` calls `dd_extract_headers_and_make_child_span`, which does not work with only baggage",
)
def test_baggage_malformed_headers_D013(self, test_library):
"""Ensure that malformed baggage headers are handled properly. Unable to use get_baggage functions because it does not return anything"""
Test_Headers_Baggage._assert_valid_baggage(self, test_library)
Expand All @@ -219,6 +227,10 @@ def test_baggage_malformed_headers_D013(self, test_library):

assert "baggage" not in headers

@missing_feature(
context.library == "nodejs",
reason="`dd_make_child_span_and_get_headers` calls `dd_extract_headers_and_make_child_span`, which does not work with only baggage",
)
def test_baggage_malformed_headers_D014(self, test_library):
Test_Headers_Baggage._assert_valid_baggage(self, test_library)

Expand All @@ -227,6 +239,10 @@ def test_baggage_malformed_headers_D014(self, test_library):

assert "baggage" not in headers

@missing_feature(
context.library == "nodejs",
reason="`dd_make_child_span_and_get_headers` calls `dd_extract_headers_and_make_child_span`, which does not work with only baggage",
)
def test_baggage_malformed_headers_D015(self, test_library):
Test_Headers_Baggage._assert_valid_baggage(self, test_library)

Expand Down

0 comments on commit 68fb7b7

Please sign in to comment.