feat: Support expressions inside Sort relations - #210
Merged
wackywendell merged 1 commit intoAug 17, 2026
Conversation
In substrait, in a SortField, we can use an expression.
We were only support direct references in the SortField.
This change adds support for SortField which are using an expression
which is not a direct field reference.
For example:
```
Root[a, b]
Sort[(add($0, $1):i32, &AscNullsFirst) => $0, $1]
Read[table => a:i32, b:i32]"#;
```
edouardmulliez
force-pushed
the
edouard.mulliez/ENINT-73/add-expr-in-sort-support
branch
from
August 17, 2026 10:43
97fc1af to
9703557
Compare
wackywendell
approved these changes
Aug 17, 2026
wackywendell
left a comment
wackywendell
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! This is a great change, shows the abstractions working well. Godo find, much appreciated!
wackywendell
deleted the
edouard.mulliez/ENINT-73/add-expr-in-sort-support
branch
August 17, 2026 16:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In substrait, in a
SortField, we can use an expression. Up to now, we were only supporting direct references in the SortField.This change adds support for
SortFieldwhich are using an expression which is not a direct field reference.For example: