Skip to content

fix: cleaning up code - #197

Draft
gord02 wants to merge 1 commit into
mainfrom
gordon.hamilton/cleaning-up-code
Draft

fix: cleaning up code#197
gord02 wants to merge 1 commit into
mainfrom
gordon.hamilton/cleaning-up-code

Conversation

@gord02

@gord02 gord02 commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR cleans up the substrait-explain codebase.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR focuses on low-risk cleanup in substrait-explain’s textifier code by removing dead/commented-out code and refactoring some relation-construction logic for clarity without changing behavior.

Changes:

  • Removed a large block of commented-out Schema textification code from src/textify/types.rs.
  • Refactored src/textify/rels.rs to reorganize helpers/impl blocks and replace some manual loops with iterator-based constructions.
  • Deleted the unused src/structural/mod.rs module implementation (no remaining references found in the crate sources).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/textify/types.rs Removes commented-out legacy Schema textifier block near the end of the file.
src/textify/rels.rs Reorganizes helper functions and Relation impls; simplifies several vector constructions.
src/structural/mod.rs Removes an apparently unused structural-value module (no mod structural; / crate::structural references found).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants