fix: cleaning up code - #197
Draft
gord02 wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on low-risk cleanup in substrait-explain’s textifier code by removing dead/commented-out code and refactoring some relation-construction logic for clarity without changing behavior.
Changes:
- Removed a large block of commented-out
Schematextification code fromsrc/textify/types.rs. - Refactored
src/textify/rels.rsto reorganize helpers/impl blocks and replace some manual loops with iterator-based constructions. - Deleted the unused
src/structural/mod.rsmodule implementation (no remaining references found in the crate sources).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/textify/types.rs | Removes commented-out legacy Schema textifier block near the end of the file. |
| src/textify/rels.rs | Reorganizes helper functions and Relation impls; simplifies several vector constructions. |
| src/structural/mod.rs | Removes an apparently unused structural-value module (no mod structural; / crate::structural references found). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up the substrait-explain codebase.