Skip to content

wip: init commit of clippy annotation reporter #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

ekump
Copy link
Contributor

@ekump ekump commented May 2, 2025

DO NOT MERGE

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@pr-commenter
Copy link

pr-commenter bot commented May 2, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-05-10 02:27:34

Comparing candidate commit 805bdd0 in PR branch ekump/clippy-annotation-action with baseline commit 6058321 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 805bdd0 1746843337 ekump/clippy-annotation-action
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 253.564ns 262.860ns ± 11.216ns 257.513ns ± 2.583ns 265.150ns 286.780ns 295.795ns 299.354ns 16.25% 1.612 1.553 4.26% 0.793ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [261.306ns; 264.415ns] or [-0.591%; +0.591%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 805bdd0 1746843337 ekump/clippy-annotation-action
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.894µs 3.912µs ± 0.003µs 3.911µs ± 0.002µs 3.914µs 3.918µs 3.921µs 3.923µs 0.29% 0.147 3.835 0.09% 0.000µs 1 200
credit_card/is_card_number/ throughput 254933237.302op/s 255637309.854op/s ± 217975.928op/s 255674931.085op/s ± 122290.459op/s 255785515.494op/s 255872475.960op/s 255912668.438op/s 256799332.261op/s 0.44% -0.132 3.891 0.09% 15413.226op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 81.951µs 82.437µs ± 0.296µs 82.365µs ± 0.143µs 82.571µs 82.896µs 83.329µs 84.390µs 2.46% 2.352 10.566 0.36% 0.021µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11849813.137op/s 12130625.524op/s ± 43185.917op/s 12141005.644op/s ± 21019.963op/s 12159769.706op/s 12178827.474op/s 12188618.754op/s 12202478.323op/s 0.51% -2.279 9.970 0.36% 3053.705op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 75.994µs 76.551µs ± 0.282µs 76.503µs ± 0.201µs 76.740µs 77.056µs 77.331µs 77.447µs 1.23% 0.623 0.046 0.37% 0.020µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 12912057.259op/s 13063337.826op/s ± 48031.223op/s 13071373.299op/s ± 34449.624op/s 13097633.589op/s 13130713.724op/s 13141385.983op/s 13158994.404op/s 0.67% -0.604 0.010 0.37% 3396.320op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.892µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.916µs 3.920µs 3.933µs 0.58% 0.966 13.645 0.09% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254230623.267op/s 255677340.795op/s ± 220361.837op/s 255707990.876op/s ± 102647.225op/s 255801578.808op/s 255911263.705op/s 256008593.020op/s 256947273.455op/s 0.48% -0.928 13.587 0.09% 15581.935op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 73.189µs 73.734µs ± 0.260µs 73.696µs ± 0.145µs 73.875µs 74.223µs 74.548µs 74.634µs 1.27% 0.835 1.242 0.35% 0.018µs 1 200
credit_card/is_card_number/378282246310005 throughput 13398694.002op/s 13562401.441op/s ± 47765.678op/s 13569201.999op/s ± 26677.090op/s 13592115.554op/s 13633134.242op/s 13651205.106op/s 13663262.271op/s 0.69% -0.808 1.183 0.35% 3377.543op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.869µs 52.194µs ± 0.282µs 52.121µs ± 0.076µs 52.224µs 52.683µs 53.215µs 54.682µs 4.91% 4.506 31.056 0.54% 0.020µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 18287678.905op/s 19159777.516op/s ± 101242.073op/s 19186284.685op/s ± 28143.065op/s 19211229.448op/s 19238685.279op/s 19273620.685op/s 19279336.397op/s 0.48% -4.308 28.555 0.53% 7158.896op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.433µs 6.638µs ± 0.083µs 6.636µs ± 0.061µs 6.704µs 6.771µs 6.807µs 6.846µs 3.17% -0.029 -0.579 1.25% 0.006µs 1 200
credit_card/is_card_number/x371413321323331 throughput 146079755.853op/s 150664430.903op/s ± 1892846.293op/s 150703765.610op/s ± 1384832.632op/s 151954061.750op/s 153663326.074op/s 154404027.793op/s 155443886.929op/s 3.15% 0.082 -0.574 1.25% 133844.445op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.894µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.916µs 3.919µs 3.921µs 0.27% -0.249 5.566 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255006942.133op/s 255667542.348op/s ± 194266.029op/s 255701099.515op/s ± 112753.158op/s 255785662.619op/s 255892428.548op/s 255989176.399op/s 256805547.884op/s 0.43% 0.266 5.647 0.08% 13736.683op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 63.494µs 63.816µs ± 0.116µs 63.796µs ± 0.057µs 63.862µs 64.069µs 64.223µs 64.294µs 0.78% 1.562 3.769 0.18% 0.008µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15553549.335op/s 15670070.349op/s ± 28423.782op/s 15674938.910op/s ± 13902.402op/s 15687664.398op/s 15702451.712op/s 15713718.044op/s 15749541.759op/s 0.48% -1.544 3.713 0.18% 2009.865op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.402µs 57.585µs ± 0.104µs 57.570µs ± 0.066µs 57.644µs 57.771µs 57.895µs 57.957µs 0.67% 0.845 0.788 0.18% 0.007µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17254213.970op/s 17365824.575op/s ± 31344.332op/s 17370172.833op/s ± 19905.883op/s 17387869.353op/s 17407933.319op/s 17416190.493op/s 17421076.018op/s 0.29% -0.834 0.758 0.18% 2216.379op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.893µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.916µs 3.918µs 3.922µs 0.30% -0.394 8.338 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254942133.520op/s 255676545.257op/s ± 182706.947op/s 255706622.815op/s ± 102591.453op/s 255798738.323op/s 255868018.301op/s 255905012.432op/s 256841790.178op/s 0.44% 0.416 8.450 0.07% 12919.332op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.554µs 54.682µs ± 0.161µs 54.632µs ± 0.035µs 54.675µs 55.077µs 55.356µs 55.441µs 1.48% 2.695 7.054 0.29% 0.011µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 18037237.137op/s 18287751.951op/s ± 53381.577op/s 18304345.452op/s ± 11595.997op/s 18314101.859op/s 18324442.791op/s 18329943.356op/s 18330626.811op/s 0.14% -2.680 6.951 0.29% 3774.647op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.883µs 52.199µs ± 0.263µs 52.106µs ± 0.077µs 52.222µs 52.715µs 53.180µs 53.532µs 2.74% 2.150 5.443 0.50% 0.019µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 18680584.480op/s 19157773.302op/s ± 95665.951op/s 19191624.795op/s ± 28512.149op/s 19213814.252op/s 19242375.463op/s 19258160.465op/s 19274174.734op/s 0.43% -2.109 5.180 0.50% 6764.604op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.437µs 6.634µs ± 0.079µs 6.632µs ± 0.053µs 6.691µs 6.760µs 6.790µs 6.817µs 2.80% -0.076 -0.608 1.19% 0.006µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 146681455.196op/s 150760642.000op/s ± 1804295.640op/s 150783343.816op/s ± 1193460.154op/s 151866259.833op/s 153679871.243op/s 154524994.526op/s 155347645.839op/s 3.03% 0.126 -0.594 1.19% 127582.968op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.911µs; 3.912µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/ throughput [255607100.487op/s; 255667519.221op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [82.396µs; 82.478µs] or [-0.050%; +0.050%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12124640.371op/s; 12136610.677op/s] or [-0.049%; +0.049%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [76.512µs; 76.590µs] or [-0.051%; +0.051%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13056681.161op/s; 13069994.492op/s] or [-0.051%; +0.051%] None None None
credit_card/is_card_number/37828224631 execution_time [3.911µs; 3.912µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/37828224631 throughput [255646800.763op/s; 255707880.826op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/378282246310005 execution_time [73.698µs; 73.770µs] or [-0.049%; +0.049%] None None None
credit_card/is_card_number/378282246310005 throughput [13555781.578op/s; 13569021.305op/s] or [-0.049%; +0.049%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.155µs; 52.233µs] or [-0.075%; +0.075%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19145746.338op/s; 19173808.693op/s] or [-0.073%; +0.073%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.627µs; 6.650µs] or [-0.174%; +0.174%] None None None
credit_card/is_card_number/x371413321323331 throughput [150402100.612op/s; 150926761.195op/s] or [-0.174%; +0.174%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.911µs; 3.912µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ throughput [255640618.945op/s; 255694465.751op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [63.800µs; 63.832µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15666131.087op/s; 15674009.612op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [57.570µs; 57.599µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17361480.552op/s; 17370168.598op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.911µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255651223.831op/s; 255701866.683op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.660µs; 54.704µs] or [-0.041%; +0.041%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18280353.778op/s; 18295150.124op/s] or [-0.040%; +0.040%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.163µs; 52.236µs] or [-0.070%; +0.070%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19144514.921op/s; 19171031.683op/s] or [-0.069%; +0.069%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.623µs; 6.645µs] or [-0.166%; +0.166%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [150510583.978op/s; 151010700.023op/s] or [-0.166%; +0.166%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 805bdd0 1746843337 ekump/clippy-annotation-action
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 5.961ms 5.974ms ± 0.011ms 5.972ms ± 0.003ms 5.976ms 5.983ms 6.021ms 6.069ms 1.62% 5.142 36.341 0.18% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [5.972ms; 5.975ms] or [-0.025%; +0.025%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 805bdd0 1746843337 ekump/clippy-annotation-action
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 72.535ms 72.971ms ± 0.279ms 72.886ms ± 0.177ms 73.139ms 73.453ms 73.691ms 74.070ms 1.62% 0.941 0.567 0.38% 0.020ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [72.932ms; 73.010ms] or [-0.053%; +0.053%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 805bdd0 1746843337 ekump/clippy-annotation-action
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.320µs 34.040µs ± 0.817µs 33.582µs ± 0.193µs 35.059µs 35.424µs 35.532µs 36.628µs 9.07% 0.937 -0.787 2.40% 0.058µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.927µs; 34.154µs] or [-0.333%; +0.333%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 805bdd0 1746843337 ekump/clippy-annotation-action
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 534.830µs 535.800µs ± 0.593µs 535.711µs ± 0.277µs 536.038µs 536.784µs 537.185µs 540.965µs 0.98% 3.642 27.426 0.11% 0.042µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1848547.824op/s 1866370.807op/s ± 2058.501op/s 1866676.886op/s ± 964.498op/s 1867603.039op/s 1868586.736op/s 1869636.973op/s 1869752.389op/s 0.16% -3.589 26.811 0.11% 145.558op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 450.302µs 450.981µs ± 0.314µs 450.935µs ± 0.198µs 451.160µs 451.567µs 451.828µs 452.093µs 0.26% 0.707 0.787 0.07% 0.022µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2211935.738op/s 2217389.750op/s ± 1543.334op/s 2217613.283op/s ± 975.015op/s 2218459.469op/s 2219604.359op/s 2220119.007op/s 2220731.864op/s 0.14% -0.702 0.775 0.07% 109.130op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 184.936µs 185.598µs ± 0.298µs 185.622µs ± 0.184µs 185.778µs 186.093µs 186.402µs 186.577µs 0.51% 0.304 0.360 0.16% 0.021µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5359726.772op/s 5387995.224op/s ± 8654.137op/s 5387292.092op/s ± 5331.129op/s 5394293.162op/s 5401696.411op/s 5406366.175op/s 5407281.147op/s 0.37% -0.293 0.343 0.16% 611.940op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 39.919µs 40.103µs ± 0.058µs 40.103µs ± 0.034µs 40.137µs 40.197µs 40.226µs 40.254µs 0.38% -0.161 0.256 0.14% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 24842396.911op/s 24936134.965op/s ± 35802.543op/s 24935731.828op/s ± 21406.255op/s 24957398.091op/s 24998137.464op/s 25020875.106op/s 25050956.593op/s 0.46% 0.171 0.262 0.14% 2531.622op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 46.566µs 46.659µs ± 0.055µs 46.656µs ± 0.034µs 46.688µs 46.761µs 46.824µs 46.892µs 0.51% 0.901 1.510 0.12% 0.004µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21325461.283op/s 21431929.988op/s ± 25461.702op/s 21433609.875op/s ± 15748.823op/s 21449867.653op/s 21468179.618op/s 21474297.481op/s 21475097.935op/s 0.19% -0.891 1.479 0.12% 1800.414op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [535.718µs; 535.882µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1866085.518op/s; 1866656.095op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [450.937µs; 451.024µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2217175.859op/s; 2217603.641op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [185.557µs; 185.640µs] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5386795.844op/s; 5389194.604op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [40.095µs; 40.111µs] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [24931173.077op/s; 24941096.853op/s] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [46.652µs; 46.667µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21428401.240op/s; 21435458.735op/s] or [-0.016%; +0.016%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 805bdd0 1746843337 ekump/clippy-annotation-action
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 147.957µs 148.681µs ± 0.394µs 148.604µs ± 0.158µs 148.781µs 149.210µs 150.088µs 151.366µs 1.86% 3.312 17.759 0.26% 0.028µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [148.627µs; 148.736µs] or [-0.037%; +0.037%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 805bdd0 1746843337 ekump/clippy-annotation-action
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.375µs 2.403µs ± 0.025µs 2.396µs ± 0.009µs 2.407µs 2.475µs 2.486µs 2.490µs 3.92% 2.188 4.439 1.02% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.399µs; 2.406µs] or [-0.142%; +0.142%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 805bdd0 1746843337 ekump/clippy-annotation-action
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 215.311µs 215.803µs ± 0.183µs 215.768µs ± 0.117µs 215.932µs 216.097µs 216.277µs 216.457µs 0.32% 0.539 0.488 0.08% 0.013µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4619858.263op/s 4633849.109op/s ± 3935.025op/s 4634608.462op/s ± 2521.724op/s 4636648.235op/s 4639380.491op/s 4641936.983op/s 4644434.070op/s 0.21% -0.533 0.480 0.08% 278.248op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 19.693µs 19.799µs ± 0.068µs 19.801µs ± 0.063µs 19.858µs 19.900µs 19.929µs 19.948µs 0.75% 0.136 -1.369 0.34% 0.005µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 50129157.560op/s 50508618.187op/s ± 174292.854op/s 50503611.851op/s ± 160883.282op/s 50703901.243op/s 50729866.195op/s 50753687.495op/s 50779817.410op/s 0.55% -0.130 -1.375 0.34% 12324.366op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 11.826µs 12.326µs ± 0.167µs 12.336µs ± 0.119µs 12.449µs 12.572µs 12.641µs 12.930µs 4.82% -0.088 0.353 1.36% 0.012µs 1 200
normalization/normalize_name/normalize_name/good throughput 77340361.639op/s 81141792.282op/s ± 1104404.959op/s 81066095.270op/s ± 773453.678op/s 81877135.812op/s 83022162.728op/s 83788154.798op/s 84562797.126op/s 4.31% 0.182 0.315 1.36% 78093.224op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [215.778µs; 215.829µs] or [-0.012%; +0.012%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4633303.752op/s; 4634394.466op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [19.789µs; 19.808µs] or [-0.048%; +0.048%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [50484462.874op/s; 50532773.500op/s] or [-0.048%; +0.048%] None None None
normalization/normalize_name/normalize_name/good execution_time [12.303µs; 12.350µs] or [-0.188%; +0.188%] None None None
normalization/normalize_name/normalize_name/good throughput [80988732.377op/s; 81294852.188op/s] or [-0.189%; +0.189%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 805bdd0 1746843337 ekump/clippy-annotation-action
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.954µs 5.027µs ± 0.045µs 5.029µs ± 0.049µs 5.055µs 5.095µs 5.098µs 5.105µs 1.52% -0.007 -1.283 0.90% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.021µs; 5.033µs] or [-0.125%; +0.125%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 805bdd0 1746843337 ekump/clippy-annotation-action
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 67.155µs 67.400µs ± 0.280µs 67.358µs ± 0.069µs 67.438µs 67.614µs 67.829µs 70.959µs 5.34% 10.425 129.347 0.41% 0.020µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [67.361µs; 67.438µs] or [-0.058%; +0.058%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 805bdd0 1746843337 ekump/clippy-annotation-action
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.227µs 3.190µs ± 1.435µs 2.987µs ± 0.027µs 3.014µs 3.679µs 13.834µs 14.905µs 398.98% 7.402 55.761 44.89% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.991µs; 3.389µs] or [-6.237%; +6.237%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 805bdd0 1746843337 ekump/clippy-annotation-action
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.680µs 25.900µs ± 10.896µs 18.030µs ± 0.269µs 34.946µs 45.179µs 57.887µs 88.862µs 392.86% 1.589 4.496 41.96% 0.770µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.390µs; 27.410µs] or [-5.830%; +5.830%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.18%. Comparing base (6058321) to head (805bdd0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1049      +/-   ##
==========================================
- Coverage   71.19%   71.18%   -0.01%     
==========================================
  Files         322      322              
  Lines       49254    49256       +2     
==========================================
- Hits        35067    35065       -2     
- Misses      14187    14191       +4     
Components Coverage Δ
datadog-crashtracker 42.43% <ø> (ø)
datadog-crashtracker-ffi 6.30% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.78% <0.00%> (-0.04%) ⬇️
data-pipeline-ffi 89.26% <ø> (ø)
ddcommon 78.28% <ø> (ø)
ddcommon-ffi 66.37% <ø> (ø)
ddtelemetry 60.56% <ø> (ø)
ddtelemetry-ffi 21.32% <ø> (ø)
dogstatsd-client 83.26% <ø> (ø)
datadog-ipc 82.68% <ø> (+0.10%) ⬆️
datadog-profiling 77.49% <ø> (ø)
datadog-profiling-ffi 62.12% <ø> (ø)
datadog-sidecar 42.63% <ø> (ø)
datdog-sidecar-ffi 12.84% <ø> (ø)
spawn-worker 54.37% <ø> (ø)
tinybytes 88.94% <ø> (ø)
datadog-trace-normalization 98.24% <ø> (ø)
datadog-trace-obfuscation 94.16% <ø> (ø)
datadog-trace-protobuf 77.10% <ø> (ø)
datadog-trace-utils 89.28% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@r1viollet
Copy link
Contributor

r1viollet commented May 2, 2025

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 20.31 MB 20.31 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.03 MB 8.03 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 66.02 MB 66.02 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 22.70 MB 22.70 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 72.62 MB 72.62 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 8.00 MB 8.00 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 16.71 MB 16.71 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 62.31 KB 62.31 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 112.66 MB 112.65 MB --.01% (-16.00 KB) 💪
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 631.94 MB 631.94 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 4.99 MB 4.99 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 62.31 KB 62.31 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 15.88 MB 15.88 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 26.43 MB 26.43 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 14.15 MB 14.15 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 63.26 KB 63.26 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 114.51 MB 114.49 MB --.02% (-24.00 KB) 💪
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 624.51 MB 624.51 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 3.78 MB 3.78 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 63.26 KB 63.26 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 16.50 MB 16.49 MB --.04% (-8.00 KB) 💪
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 24.34 MB 24.34 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 57.50 MB 57.50 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.43 MB 8.43 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 18.71 MB 18.71 MB -0% (-8 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 68.60 MB 68.60 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 8.43 MB 8.43 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 20.90 MB 20.90 MB 0% (0 B) 👌

@ekump ekump force-pushed the ekump/clippy-annotation-action branch from 4dae85a to a1c1a9d Compare May 2, 2025 17:05
@DataDog DataDog deleted a comment from github-actions bot May 2, 2025
@ekump ekump force-pushed the ekump/clippy-annotation-action branch from 4db63c3 to c0d22c4 Compare May 2, 2025 19:07
@DataDog DataDog deleted a comment from github-actions bot May 2, 2025
@DataDog DataDog deleted a comment from github-actions bot May 2, 2025
@DataDog DataDog deleted a comment from github-actions bot May 2, 2025
@DataDog DataDog deleted a comment from github-actions bot May 2, 2025
@DataDog DataDog deleted a comment from github-actions bot May 2, 2025
@DataDog DataDog deleted a comment from github-actions bot May 2, 2025
@DataDog DataDog deleted a comment from github-actions bot May 2, 2025
@DataDog DataDog deleted a comment from github-actions bot May 2, 2025
@DataDog DataDog deleted a comment from github-actions bot May 2, 2025
Copy link

github-actions bot commented May 2, 2025

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

  • Base Branch: origin/main
  • PR Branch: origin/ekump/clippy-annotation-action

Summary by Rule

Rule Base Branch PR Branch Change
unwrap_used 7 8 ⚠️ +1 (+14.3%)
Total 7 8 ⚠️ +1 (+14.3%)

Annotation Counts by File

File Base Branch PR Branch Change
data-pipeline/src/trace_exporter/mod.rs 7 8 ⚠️ +1 (+14.3%)

Annotation Stats by Crate

Crate Base Branch PR Branch Change
data-pipeline 10 11 ⚠️ +1 (+10.0%)
datadog-crashtracker 5 5 No change (0%)
datadog-ipc 27 27 No change (0%)
datadog-live-debugger 6 6 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling 11 11 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-remote-config 3 3 No change (0%)
datadog-sidecar 56 56 No change (0%)
datadog-trace-normalization 2 2 No change (0%)
datadog-trace-obfuscation 8 8 No change (0%)
datadog-trace-utils 17 17 No change (0%)
ddcommon 13 13 No change (0%)
ddcommon-ffi 8 8 No change (0%)
ddsketch 2 2 No change (0%)
ddtelemetry 19 19 No change (0%)
dogstatsd-client 1 1 No change (0%)
tinybytes 3 3 No change (0%)
Total 205 206 ⚠️ +1 (+0.5%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

@DataDog DataDog deleted a comment from github-actions bot May 2, 2025
@ekump ekump force-pushed the ekump/clippy-annotation-action branch 4 times, most recently from e117b3e to 14d2b50 Compare May 5, 2025 19:38
@ekump ekump force-pushed the ekump/clippy-annotation-action branch from 14d2b50 to 196838e Compare May 8, 2025 12:38
@ekump ekump force-pushed the ekump/clippy-annotation-action branch from 196838e to 78c37d6 Compare May 8, 2025 13:02
@ekump ekump force-pushed the ekump/clippy-annotation-action branch from 92c3830 to 145fb3f Compare May 9, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants