Skip to content

Replace rustls-native-certs by rustls-platform-verifier #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace rustls-native-certs by rustls-platform-verifier #1035

wants to merge 2 commits into from

Conversation

VianneyRuhlmann
Copy link
Contributor

@VianneyRuhlmann VianneyRuhlmann commented Apr 22, 2025 •
edited
Loading

What does this PR do?

Replace rustls-native-certs by rustls-platform-verifier as recommended in native-certs doc

Motivation

rustls-native-certs is causing some issues when dropping the tokio runtime to prepare for forking on macos.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@pr-commenter
Copy link

pr-commenter bot commented Apr 22, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-04-22 17:24:24

Comparing candidate commit 2926133 in PR branch vianney/use_platform_verifier with baseline commit a303dc1 in branch main.

Found 8 performance improvements and 8 performance regressions! Performance is the same for 36 metrics, 2 unstable metrics.

scenario:credit_card/is_card_number/ 3782-8224-6310-005

  • 🟩 execution_time [-6.376µs; -6.187µs] or [-7.599%; -7.374%]
  • 🟩 throughput [+949902.369op/s; +979223.312op/s] or [+7.970%; +8.216%]

scenario:credit_card/is_card_number/ 378282246310005

  • 🟩 execution_time [-8.697µs; -8.581µs] or [-10.865%; -10.720%]
  • 🟩 throughput [+1501359.125op/s; +1521358.453op/s] or [+12.018%; +12.178%]

scenario:credit_card/is_card_number/378282246310005

  • 🟩 execution_time [-9.164µs; -9.035µs] or [-11.897%; -11.730%]
  • 🟩 throughput [+1726489.415op/s; +1752376.087op/s] or [+13.298%; +13.498%]

scenario:normalization/normalize_name/normalize_name/bad-name

  • 🟥 execution_time [+1.105µs; +1.130µs] or [+5.910%; +6.041%]
  • 🟥 throughput [-3046346.162op/s; -2982162.292op/s] or [-5.697%; -5.577%]

scenario:normalization/normalize_name/normalize_name/good

  • 🟥 execution_time [+1.161µs; +1.184µs] or [+10.554%; +10.759%]
  • 🟥 throughput [-8825415.735op/s; -8671676.674op/s] or [-9.711%; -9.542%]

scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...

  • 🟥 execution_time [+31.639µs; +32.749µs] or [+6.264%; +6.484%]
  • 🟥 throughput [-120506.164op/s; -116625.195op/s] or [-6.086%; -5.890%]

scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters

  • 🟥 execution_time [+7.997µs; +8.100µs] or [+4.501%; +4.559%]
  • 🟥 throughput [-245466.587op/s; -242401.231op/s] or [-4.361%; -4.306%]

scenario:normalization/normalize_service/normalize_service/test_ASCII

  • 🟩 execution_time [-2.411µs; -2.363µs] or [-4.993%; -4.893%]
  • 🟩 throughput [+1066085.100op/s; +1088059.152op/s] or [+5.148%; +5.254%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2926133 1745341939 vianney/use_platform_verifier
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 71.628ms 72.028ms ± 0.223ms 72.015ms ± 0.140ms 72.145ms 72.355ms 72.676ms 73.296ms 1.78% 1.539 6.052 0.31% 0.016ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [71.997ms; 72.059ms] or [-0.043%; +0.043%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2926133 1745341939 vianney/use_platform_verifier
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.894µs 3.913µs ± 0.003µs 3.912µs ± 0.001µs 3.914µs 3.916µs 3.918µs 3.921µs 0.21% -1.718 11.552 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 255062455.874op/s 255581197.395op/s ± 173205.937op/s 255593891.307op/s ± 80254.893op/s 255657516.552op/s 255847787.336op/s 256042246.087op/s 256795872.700op/s 0.47% 1.740 11.711 0.07% 12247.509op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 76.760µs 77.628µs ± 0.500µs 77.596µs ± 0.397µs 77.962µs 78.534µs 78.814µs 78.897µs 1.68% 0.509 -0.622 0.64% 0.035µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12674832.862op/s 12882545.975op/s ± 82636.417op/s 12887246.137op/s ± 66283.693op/s 12955914.520op/s 12990701.214op/s 13012463.532op/s 13027655.390op/s 1.09% -0.487 -0.652 0.64% 5843.277op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 70.932µs 71.407µs ± 0.258µs 71.391µs ± 0.170µs 71.551µs 71.841µs 72.180µs 72.551µs 1.62% 1.001 1.779 0.36% 0.018µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13783475.385op/s 14004375.101op/s ± 50367.342op/s 14007334.240op/s ± 33198.966op/s 14041509.531op/s 14072682.167op/s 14083749.356op/s 14097980.968op/s 0.65% -0.972 1.664 0.36% 3561.509op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.895µs 3.913µs ± 0.003µs 3.913µs ± 0.001µs 3.915µs 3.918µs 3.920µs 3.922µs 0.22% -1.086 8.493 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254981364.214op/s 255550263.098op/s ± 187936.725op/s 255553808.663op/s ± 90302.729op/s 255641202.976op/s 255843396.667op/s 256016475.313op/s 256765845.321op/s 0.47% 1.106 8.614 0.07% 13289.133op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 67.189µs 67.926µs ± 0.374µs 67.890µs ± 0.255µs 68.200µs 68.556µs 68.835µs 69.098µs 1.78% 0.443 -0.190 0.55% 0.026µs 1 200
credit_card/is_card_number/378282246310005 throughput 14472157.866op/s 14722266.653op/s ± 80862.578op/s 14729764.801op/s ± 55391.714op/s 14780914.883op/s 14839236.508op/s 14866028.018op/s 14883370.689op/s 1.04% -0.417 -0.231 0.55% 5717.848op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.669µs 51.785µs ± 0.036µs 51.787µs ± 0.021µs 51.808µs 51.838µs 51.867µs 51.871µs 0.16% -0.327 0.233 0.07% 0.003µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19278476.197op/s 19310511.714op/s ± 13295.222op/s 19309752.973op/s ± 7981.041op/s 19318119.186op/s 19333229.020op/s 19343052.878op/s 19354128.779op/s 0.23% 0.331 0.237 0.07% 940.114op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.029µs 6.042µs ± 0.014µs 6.038µs ± 0.002µs 6.041µs 6.076µs 6.101µs 6.107µs 1.15% 2.499 6.007 0.23% 0.001µs 1 200
credit_card/is_card_number/x371413321323331 throughput 163739704.100op/s 165513390.918op/s ± 380950.131op/s 165620338.178op/s ± 60823.533op/s 165675071.524op/s 165837652.822op/s 165871015.659op/s 165878227.551op/s 0.16% -2.487 5.931 0.23% 26937.242op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.897µs 3.913µs ± 0.002µs 3.913µs ± 0.001µs 3.914µs 3.916µs 3.917µs 3.918µs 0.13% -1.795 9.892 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255256058.663op/s 255587131.685op/s ± 152593.737op/s 255577361.212op/s ± 66001.001op/s 255646320.669op/s 255836657.148op/s 255959850.941op/s 256620549.234op/s 0.41% 1.810 10.008 0.06% 10790.007op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 66.029µs 66.545µs ± 0.397µs 66.396µs ± 0.254µs 66.808µs 67.335µs 67.570µs 67.917µs 2.29% 0.897 0.238 0.59% 0.028µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14723826.838op/s 15028021.505op/s ± 89171.756op/s 15061177.064op/s ± 57717.625op/s 15101401.789op/s 15128495.593op/s 15140854.501op/s 15144811.984op/s 0.56% -0.872 0.161 0.59% 6305.395op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 59.479µs 59.637µs ± 0.062µs 59.636µs ± 0.044µs 59.675µs 59.747µs 59.787µs 59.871µs 0.39% 0.458 0.576 0.10% 0.004µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16702537.354op/s 16768197.174op/s ± 17479.644op/s 16768302.878op/s ± 12299.116op/s 16781711.296op/s 16793296.704op/s 16804961.544op/s 16812772.663op/s 0.27% -0.450 0.564 0.10% 1235.997op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.895µs 3.913µs ± 0.003µs 3.913µs ± 0.001µs 3.915µs 3.917µs 3.919µs 3.921µs 0.19% -1.559 11.638 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255058561.685op/s 255549348.420op/s ± 166858.417op/s 255553680.895op/s ± 78733.974op/s 255624162.874op/s 255804250.741op/s 255960269.499op/s 256721539.389op/s 0.46% 1.581 11.794 0.07% 11798.672op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 56.191µs 56.438µs ± 0.105µs 56.444µs ± 0.068µs 56.494µs 56.618µs 56.715µs 56.823µs 0.67% 0.333 0.343 0.19% 0.007µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17598458.929op/s 17718503.286op/s ± 32882.170op/s 17716554.145op/s ± 21200.045op/s 17742028.369op/s 17770138.263op/s 17780538.550op/s 17796424.698op/s 0.45% -0.321 0.320 0.19% 2325.121op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.694µs 51.793µs ± 0.036µs 51.794µs ± 0.019µs 51.814µs 51.844µs 51.882µs 51.986µs 0.37% 0.512 3.570 0.07% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19235976.750op/s 19307659.407op/s ± 13560.633op/s 19307346.938op/s ± 7178.027op/s 19314026.509op/s 19330935.210op/s 19338579.377op/s 19344678.090op/s 0.19% -0.501 3.525 0.07% 958.882op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.027µs 6.040µs ± 0.013µs 6.037µs ± 0.002µs 6.040µs 6.077µs 6.086µs 6.119µs 1.36% 3.118 10.697 0.21% 0.001µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 163420974.702op/s 165554902.025op/s ± 349311.019op/s 165638639.541op/s ± 65234.230op/s 165697391.170op/s 165815772.095op/s 165898448.098op/s 165922371.990op/s 0.17% -3.100 10.537 0.21% 24700.019op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.912µs; 3.913µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ throughput [255557192.718op/s; 255605202.072op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [77.558µs; 77.697µs] or [-0.089%; +0.089%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12871093.363op/s; 12893998.588op/s] or [-0.089%; +0.089%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [71.371µs; 71.443µs] or [-0.050%; +0.050%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13997394.671op/s; 14011355.530op/s] or [-0.050%; +0.050%] None None None
credit_card/is_card_number/37828224631 execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255524216.875op/s; 255576309.321op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [67.875µs; 67.978µs] or [-0.076%; +0.076%] None None None
credit_card/is_card_number/378282246310005 throughput [14711059.877op/s; 14733473.428op/s] or [-0.076%; +0.076%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [51.780µs; 51.790µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19308669.124op/s; 19312354.304op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.040µs; 6.044µs] or [-0.032%; +0.032%] None None None
credit_card/is_card_number/x371413321323331 throughput [165460594.893op/s; 165566186.942op/s] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.913µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ throughput [255565983.661op/s; 255608279.710op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [66.490µs; 66.600µs] or [-0.083%; +0.083%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15015663.157op/s; 15040379.852op/s] or [-0.082%; +0.082%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [59.628µs; 59.645µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [16765774.663op/s; 16770619.684op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.913µs; 3.913µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255526223.448op/s; 255572473.391op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [56.424µs; 56.453µs] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [17713946.134op/s; 17723060.439op/s] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [51.788µs; 51.798µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19305780.034op/s; 19309538.780op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.039µs; 6.042µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165506490.877op/s; 165603313.172op/s] or [-0.029%; +0.029%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2926133 1745341939 vianney/use_platform_verifier
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 533.245µs 537.273µs ± 3.705µs 536.057µs ± 2.053µs 539.275µs 544.401µs 547.779µs 551.148µs 2.82% 1.182 0.975 0.69% 0.262µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1814393.520op/s 1861338.460op/s ± 12733.202op/s 1865471.936op/s ± 7170.841op/s 1871814.355op/s 1873920.047op/s 1874575.615op/s 1875309.978op/s 0.53% -1.150 0.853 0.68% 900.373op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 448.342µs 449.253µs ± 0.348µs 449.252µs ± 0.226µs 449.482µs 449.780µs 450.027µs 450.153µs 0.20% -0.118 0.017 0.08% 0.025µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2221467.910op/s 2225916.929op/s ± 1723.455op/s 2225921.456op/s ± 1119.519op/s 2226997.338op/s 2228753.920op/s 2230295.891op/s 2230438.911op/s 0.20% 0.122 0.018 0.08% 121.867op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 184.541µs 185.706µs ± 0.321µs 185.690µs ± 0.210µs 185.951µs 186.183µs 186.262µs 186.302µs 0.33% -0.465 0.308 0.17% 0.023µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5367628.904op/s 5384883.918op/s ± 9322.390op/s 5385325.057op/s ± 6089.993op/s 5390601.466op/s 5399975.111op/s 5408770.549op/s 5418863.960op/s 0.62% 0.476 0.334 0.17% 659.193op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 38.675µs 38.821µs ± 0.072µs 38.813µs ± 0.041µs 38.859µs 38.914µs 39.012µs 39.323µs 1.31% 2.026 11.245 0.19% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 25430619.024op/s 25759594.281op/s ± 47738.038op/s 25764772.544op/s ± 27166.716op/s 25789189.254op/s 25822836.860op/s 25853191.526op/s 25856573.735op/s 0.36% -1.976 10.840 0.18% 3375.589op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.759µs 45.903µs ± 0.170µs 45.900µs ± 0.033µs 45.923µs 45.969µs 45.995µs 48.195µs 5.00% 12.437 165.926 0.37% 0.012µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20748877.716op/s 21785397.600op/s ± 76950.061op/s 21786421.179op/s ± 15475.715op/s 21806584.680op/s 21828903.922op/s 21846098.563op/s 21853709.327op/s 0.31% -12.288 163.289 0.35% 5441.191op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [536.760µs; 537.786µs] or [-0.096%; +0.096%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1859573.760op/s; 1863103.159op/s] or [-0.095%; +0.095%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [449.205µs; 449.302µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2225678.074op/s; 2226155.783op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [185.661µs; 185.750µs] or [-0.024%; +0.024%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5383591.924op/s; 5386175.911op/s] or [-0.024%; +0.024%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [38.811µs; 38.831µs] or [-0.026%; +0.026%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [25752978.248op/s; 25766210.314op/s] or [-0.026%; +0.026%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.879µs; 45.926µs] or [-0.051%; +0.051%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21774733.061op/s; 21796062.138op/s] or [-0.049%; +0.049%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2926133 1745341939 vianney/use_platform_verifier
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 32.524µs 33.505µs ± 1.196µs 32.809µs ± 0.120µs 35.119µs 35.562µs 35.698µs 35.845µs 9.25% 0.929 -1.050 3.56% 0.085µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.339µs; 33.670µs] or [-0.495%; +0.495%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2926133 1745341939 vianney/use_platform_verifier
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 212.346µs 213.015µs ± 0.255µs 212.997µs ± 0.171µs 213.165µs 213.439µs 213.751µs 213.879µs 0.41% 0.533 0.591 0.12% 0.018µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4675536.593op/s 4694505.079op/s ± 5623.605op/s 4694901.806op/s ± 3761.864op/s 4698713.897op/s 4702178.788op/s 4704738.859op/s 4709287.814op/s 0.31% -0.525 0.578 0.12% 397.649op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 19.717µs 19.820µs ± 0.076µs 19.807µs ± 0.068µs 19.893µs 19.929µs 19.958µs 20.003µs 0.99% 0.305 -1.340 0.38% 0.005µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 49991860.300op/s 50454878.612op/s ± 193165.186op/s 50485959.729op/s ± 173807.973op/s 50652837.144op/s 50677168.312op/s 50711439.013op/s 50718556.229op/s 0.46% -0.299 -1.347 0.38% 13658.841op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 12.044µs 12.177µs ± 0.078µs 12.160µs ± 0.031µs 12.196µs 12.367µs 12.422µs 12.577µs 3.43% 1.903 4.596 0.64% 0.006µs 1 200
normalization/normalize_name/normalize_name/good throughput 79509022.396op/s 82127968.945op/s ± 520984.679op/s 82238093.618op/s ± 209496.442op/s 82430853.415op/s 82716255.957op/s 82799121.272op/s 83029654.008op/s 0.96% -1.847 4.303 0.63% 36839.180op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [212.980µs; 213.051µs] or [-0.017%; +0.017%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4693725.702op/s; 4695284.457op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [19.809µs; 19.831µs] or [-0.053%; +0.053%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [50428107.775op/s; 50481649.449op/s] or [-0.053%; +0.053%] None None None
normalization/normalize_name/normalize_name/good execution_time [12.166µs; 12.187µs] or [-0.089%; +0.089%] None None None
normalization/normalize_name/normalize_name/good throughput [82055765.479op/s; 82200172.411op/s] or [-0.088%; +0.088%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2926133 1745341939 vianney/use_platform_verifier
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 251.365ns 262.730ns ± 13.132ns 257.344ns ± 4.056ns 264.386ns 291.481ns 299.293ns 304.750ns 18.42% 1.575 1.316 4.99% 0.929ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [260.910ns; 264.550ns] or [-0.693%; +0.693%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2926133 1745341939 vianney/use_platform_verifier
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 149.736µs 150.584µs ± 0.409µs 150.552µs ± 0.177µs 150.718µs 151.035µs 151.781µs 154.088µs 2.35% 4.000 28.313 0.27% 0.029µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [150.527µs; 150.640µs] or [-0.038%; +0.038%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2926133 1745341939 vianney/use_platform_verifier
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.406µs 2.436µs ± 0.053µs 2.418µs ± 0.006µs 2.426µs 2.598µs 2.615µs 2.618µs 8.29% 2.755 5.864 2.18% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.428µs; 2.443µs] or [-0.304%; +0.304%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2926133 1745341939 vianney/use_platform_verifier
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.189µs 3.188µs ± 1.428µs 2.994µs ± 0.025µs 3.018µs 3.619µs 13.883µs 14.972µs 400.08% 7.423 55.967 44.66% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.991µs; 3.386µs] or [-6.205%; +6.205%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2926133 1745341939 vianney/use_platform_verifier
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 5.930ms 5.944ms ± 0.008ms 5.943ms ± 0.003ms 5.946ms 5.953ms 5.965ms 6.020ms 1.29% 4.764 39.973 0.14% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [5.943ms; 5.945ms] or [-0.019%; +0.019%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2926133 1745341939 vianney/use_platform_verifier
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 67.073µs 67.266µs ± 0.166µs 67.239µs ± 0.044µs 67.290µs 67.477µs 67.641µs 69.092µs 2.76% 7.447 74.696 0.25% 0.012µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [67.243µs; 67.289µs] or [-0.034%; +0.034%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2926133 1745341939 vianney/use_platform_verifier
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.672µs 26.333µs ± 11.413µs 18.088µs ± 0.185µs 35.645µs 45.508µs 46.978µs 93.209µs 415.30% 1.808 6.237 43.23% 0.807µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.751µs; 27.915µs] or [-6.007%; +6.007%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2926133 1745341939 vianney/use_platform_verifier
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.949µs 5.005µs ± 0.025µs 5.009µs ± 0.022µs 5.028µs 5.037µs 5.041µs 5.042µs 0.67% -0.280 -1.431 0.51% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.001µs; 5.009µs] or [-0.070%; +0.070%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.57%. Comparing base (a303dc1) to head (2926133).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1035      +/-   ##
==========================================
+ Coverage   71.55%   71.57%   +0.01%     
==========================================
  Files         339      339              
  Lines       50668    50668              
==========================================
+ Hits        36258    36266       +8     
+ Misses      14410    14402       -8
Components Coverage Δ
crashtracker 42.84% <ø> (+0.02%) ⬆️
crashtracker-ffi 6.30% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.83% <ø> (ø)
data-pipeline-ffi 90.30% <ø> (ø)
ddcommon 78.57% <ø> (ø)
ddcommon-ffi 66.37% <ø> (ø)
ddtelemetry 60.19% <ø> (ø)
ddtelemetry-ffi 21.32% <ø> (ø)
dogstatsd-client 82.57% <ø> (ø)
ipc 82.51% <ø> (+0.10%) ⬆️
profiling 77.49% <ø> (ø)
profiling-ffi 62.12% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 41.59% <ø> (-0.23%) ⬇️
sidecar-ffi 5.54% <ø> (-1.76%) ⬇️
spawn-worker 54.37% <ø> (ø)
tinybytes 89.86% <ø> (ø)
trace-mini-agent 73.80% <ø> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 96.00% <ø> (ø)
trace-protobuf 78.50% <ø> (ø)
trace-utils 92.99% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@VianneyRuhlmann VianneyRuhlmann force-pushed the vianney/use_platform_verifier branch from 203a58e to 978894a Compare April 22, 2025 13:07
@r1viollet
Copy link
Contributor

r1viollet commented Apr 22, 2025 •
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 23.71 MB 20.50 MB --13.53% (-3.20 MB) 💪
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 76.92 MB 66.49 MB --13.55% (-10.43 MB) 💪
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.70 MB 8.04 MB +4.42% (+349.34 KB) ⚠️
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 22.31 MB 22.94 MB +2.80% (+641.71 KB) ⚠️
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 7.63 MB 8.02 MB +5.07% (+396.92 KB) 🚨
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 71.26 MB 73.22 MB +2.75% (+1.96 MB) ⚠️
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 16.73 MB 16.50 MB --1.31% (-226.00 KB) 💪
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 61.83 KB 61.83 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 112.72 MB 112.31 MB --.36% (-416.00 KB) 💪
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 632.28 MB 635.54 MB +.51% (+3.25 MB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 4.99 MB 4.96 MB --.47% (-24.50 KB) 💪
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 61.83 KB 61.83 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 15.86 MB 15.74 MB --.73% (-120.00 KB) 💪
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 26.39 MB 26.21 MB --.65% (-177.30 KB) 💪
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 14.14 MB 13.94 MB --1.36% (-197.50 KB) 💪
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 62.78 KB 62.78 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 114.61 MB 114.17 MB --.38% (-448.00 KB) 💪
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 624.67 MB 627.86 MB +.51% (+3.19 MB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 3.77 MB 3.75 MB --.52% (-20.50 KB) 💪
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 62.78 KB 62.78 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 16.47 MB 16.37 MB --.61% (-104.00 KB) 💪
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 24.31 MB 24.17 MB --.57% (-142.91 KB) 💪
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 66.28 MB 58.04 MB --12.43% (-8.23 MB) 💪
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.18 MB 8.50 MB +3.85% (+323.57 KB) ⚠️
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 22.89 MB 18.92 MB --17.36% (-3.97 MB) 💪
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 67.25 MB 69.16 MB +2.83% (+1.90 MB) ⚠️
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 8.07 MB 8.50 MB +5.38% (+444.81 KB) 🚨
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 20.54 MB 21.12 MB +2.82% (+593.84 KB) ⚠️

@VianneyRuhlmann VianneyRuhlmann force-pushed the vianney/use_platform_verifier branch from f6fc94f to 2926133 Compare April 22, 2025 17:12
@VianneyRuhlmann VianneyRuhlmann marked this pull request as ready for review April 23, 2025 09:38
@VianneyRuhlmann VianneyRuhlmann requested review from a team as code owners April 23, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoolioh hoolioh hoolioh approved these changes

Assignees
No one assigned
Labels
common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VianneyRuhlmann @codecov-commenter @r1viollet @hoolioh