Track operation time for SQL Server database metric executors - #24954
Open
jasonmp85 wants to merge 4 commits into
Open
Track operation time for SQL Server database metric executors#24954jasonmp85 wants to merge 4 commits into
jasonmp85 wants to merge 4 commits into
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: f671087 | Docs | View more details | Give us feedback! |
evalya-impact-summaryevalya impact analysis |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32f43ccb35
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
jasonmp85
force-pushed
the
jmp/sqlserver-3c-operation-time
branch
from
August 21, 2026 21:58
32f43cc to
6238bef
Compare
Contributor
Validation ReportAll 21 validations passed. Show details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Passes
track_operation_timethrough when constructing database metric executors, so each collector reports how long it took.Measured effect
With this branch, a single check run against a 3,945-database bench instance attributes its own cost, which previously required a custom harness running each collector in isolation:
That table is the entire point of the change: it identifies file stats as 69% of a 918.8 ms collection immediately, from telemetry alone. This measurement is what scoped the fix in #24952.
Motivation
There is currently no per-collector timing for database metrics, which makes it impossible to tell from telemetry alone which collector is responsible for a slow collection interval. Support cases involving slow SQL Server checks presently require reproducing the customer's schema locally to find out where the time goes.
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged