Skip to content

Conversation

JacksonDavenport
Copy link
Contributor

What does this PR do?

Replaces the {{< highlight yaml "hl_lines=15-37" >}} syntax with the simple ```yaml syntax. This does lose out on the line highlighting but fixes the currently broken YAML indentation. It looks like this is the only integrations-core sample that uses this syntax.

Motivation

https://datadoghq.atlassian.net/browse/DOCSENG-93

Broken yaml sample
image

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

github-actions bot commented Sep 2, 2025

⚠️ Recommendation: Add qa/skip-qa Label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

@JacksonDavenport JacksonDavenport added the qa/skip-qa Automatically skip this PR for the next QA label Sep 2, 2025
@urseberry
Copy link
Contributor

Copy link
Contributor

@urseberry urseberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The YAML still looks broken to me.
Screenshot 2025-09-02 at 4 49 37 PM

@JacksonDavenport
Copy link
Contributor Author

@urseberry Is that preview loading the branch correctly? I see its still showing the highlighting which should be gone all together now

image

@urseberry
Copy link
Contributor

@urseberry Is that preview loading the branch correctly? I see its still showing the highlighting which should be gone all together now

Good point. Probably not, then. I know the preview build for integrations runs on a schedule. I would have expected it to finish after an hour, but perhaps it takes longer. I'll check back on it tomorrow morning.

@urseberry
Copy link
Contributor

I asked for help in Slack in #integrations-developer-platform on why the APW pipeline seems to be stuck.

@urseberry
Copy link
Contributor

See Slack threads:
https://dd.slack.com/archives/C072SLTQX1Q/p1756920586794799
https://dd.slack.com/archives/C4TQDFK1P/p1756926463340159
This integration has an unusual setup where there are multiple integrations and docs pages, but only one tile. The EKS Fargate integration is explicitly disabled in the APW pipeline, which means that the docs can't be updated.

You will have to wait on this PR until James and Steven agree on and implement a solution.

@urseberry
Copy link
Contributor

urseberry commented Sep 4, 2025

See Slack threads: https://dd.slack.com/archives/C072SLTQX1Q/p1756920586794799 https://dd.slack.com/archives/C4TQDFK1P/p1756926463340159 This integration has an unusual setup where there are multiple integrations and docs pages, but only one tile. The EKS Fargate integration is explicitly disabled in the APW pipeline, which means that the docs can't be updated.

You will have to wait on this PR until James and Steven agree on and implement a solution.

My previous message was incorrect. We can't preview the change, but merging the PR will still update the docs. I approved.

Internal docs that explain the setup: https://datadoghq.atlassian.net/wiki/spaces/WEB/pages/4981459979/Integrations#Exceptions-(Integrations-that-are-sourced-from-Github)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants