-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Replace hugo highlight syntax with native code blocks #21231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
For my reference, the preview is here: https://docs-staging.datadoghq.com/guacbot/websites-sources/integrations/eks_fargate/?tab=admissioncontrollerdatadogoperator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@urseberry Is that preview loading the branch correctly? I see its still showing the highlighting which should be gone all together now ![]() |
Good point. Probably not, then. I know the preview build for integrations runs on a schedule. I would have expected it to finish after an hour, but perhaps it takes longer. I'll check back on it tomorrow morning. |
I asked for help in Slack in #integrations-developer-platform on why the APW pipeline seems to be stuck. |
See Slack threads: You will have to wait on this PR until James and Steven agree on and implement a solution. |
My previous message was incorrect. We can't preview the change, but merging the PR will still update the docs. I approved. Internal docs that explain the setup: https://datadoghq.atlassian.net/wiki/spaces/WEB/pages/4981459979/Integrations#Exceptions-(Integrations-that-are-sourced-from-Github) |
What does this PR do?
Replaces the
{{< highlight yaml "hl_lines=15-37" >}}
syntax with the simple ```yaml syntax. This does lose out on the line highlighting but fixes the currently broken YAML indentation. It looks like this is the only integrations-core sample that uses this syntax.Motivation
https://datadoghq.atlassian.net/browse/DOCSENG-93
Broken yaml sample

Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged