Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AI-4911] Refactor octopus test fixtures #19481

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

sarah-witt
Copy link
Contributor

@sarah-witt sarah-witt commented Jan 24, 2025

What does this PR do?

Refactors octopus deploy test fixtures by using a flattened directory structure when there are request parameters. Permanent solution to replace #19434

Motivation

address windows compatibility concerns in a less brittle way

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@sarah-witt sarah-witt changed the title Refactor test fixtures [AI-4911] Refactor test fixtures Jan 24, 2025
@sarah-witt sarah-witt marked this pull request as ready for review January 24, 2025 21:31
@sarah-witt sarah-witt requested a review from a team as a code owner January 24, 2025 21:31
@sarah-witt sarah-witt changed the title [AI-4911] Refactor test fixtures [AI-4911] Refactor octopus test fixtures Jan 24, 2025
@sarah-witt
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 28, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-28 15:36:41 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-28 19:37:08 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@sarah-witt
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 28, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-28 20:19:14 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-28 20:21:17 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@sarah-witt
Copy link
Contributor Author

/remove

@dd-devflow
Copy link

dd-devflow bot commented Jan 28, 2025

Devflow running: /remove

View all feedbacks in Devflow UI.


2025-01-28 20:21:14 UTC ℹ️ Devflow: /remove

@sarah-witt sarah-witt added this pull request to the merge queue Jan 29, 2025
Merged via the queue into master with commit 8841bbd Jan 29, 2025
48 of 52 checks passed
@sarah-witt sarah-witt deleted the sarah/fix-octopus-test-directory branch January 29, 2025 16:33
@sarah-witt sarah-witt mentioned this pull request Jan 29, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants