-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for sampling idle recently active sessions #19479
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nenadnoveljic
changed the title
Add option for sampling idle recently active session
Add option for sampling idle recently active sessions
Jan 24, 2025
lu-zhengda
previously approved these changes
Jan 24, 2025
lu-zhengda
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
agent/review-requested
ecosystems/review-requested
product/review-requested
qa/skip-qa
Automatically skip this PR for the next QA
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an option to sample recently active idle sessions.
Motivation
Improve APM/DBM correlation by ~3x.
For example, the execution plan for the query below, which ran in 2ms, was captured only after several executions:
Details
Capturing queries is essential for APM/DBM correlation. Currently, only active sessions are sampled, missing many fast queries. By sampling idle sessions that were recently active, we can significantly increase the number of captured queries.
Trade off
The option is disabled by default because, in SQL Server, identifying queries from idle sessions requires a second scan, doubling activity collection time.
Dependencies
Sampled idle sessions are excluded from the active sessions graph but appear in the samples with the
Wait Event
set toOther
. If we don't filter them, they should be marked asIdle
.Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged