Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump datadog-checks-base version #19478

Conversation

sethsamuel
Copy link
Contributor

@sethsamuel sethsamuel commented Jan 24, 2025

What does this PR do?

Bumps the dependency for DBM checks to properly include stub for emit_agent_telemetry.

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

lu-zhengda
lu-zhengda previously approved these changes Jan 24, 2025
nubtron
nubtron previously approved these changes Jan 24, 2025
@sethsamuel sethsamuel dismissed stale reviews from nubtron and lu-zhengda via 7d140b2 January 24, 2025 15:19
@sethsamuel sethsamuel added the qa/skip-qa Automatically skip this PR for the next QA label Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.64%. Comparing base (d94c94b) to head (7d140b2).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
mysql 89.59% <ø> (+0.08%) ⬆️
postgres 93.42% <ø> (+3.73%) ⬆️
presto ?
solr ?
sqlserver 91.59% <ø> (+9.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sethsamuel sethsamuel added this pull request to the merge queue Jan 24, 2025
Merged via the queue into master with commit 3660d76 Jan 24, 2025
46 of 49 checks passed
@sethsamuel sethsamuel deleted the seth.samuel/DBMON-4936-dbm-integration-checks-are-failing-in-compat-mode branch January 24, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants