Add additional Teleport metrics #19473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
force-pushed
the
update_teleport_metrics
branch
from
e733ed9 to
d9db289
Compare
rosstimothy
force-pushed
the
update_teleport_metrics
branch
7 times, most recently
from
de2d376 to
2b1872c
Compare
neko-dd
previously approved these changes
Jan 24, 2025
temporal-github-worker-1
bot
added
docs/approved
and removed
docs/review-requested
labels
temporal-github-worker-1
bot
added
docs/review-requested
and removed
docs/approved
labels
In addition to adding the Teleport auth heartbeat_connections_received and teleport_roles metrics, this cleans up a few typos and updates Teleport image and tag used in the docker tests.
rosstimothy
force-pushed
the
update_teleport_metrics
branch
from
70563d0 to
8809b44
Compare
neko-dd
approved these changes
Jan 28, 2025
|
@neko-dd is there anything else that I need to do to get this merged and into a release? |
|
I think you need a review from the agent-integrations team. The Documentation team doesn't merge PRs in this repo. I'm guessing agent-integrations does? |
|
Looks like you can ping #agent-integrations-reviews on slack for a review |
|
@NouemanKHAL could you help get this PR reviewed? |
temporal-github-worker-1
bot
added
docs/review-requested
and removed
docs/approved
labels
|
Hey @rosstimothy, Thanks for your contribution! |
NouemanKHAL
approved these changes
Feb 19, 2025
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/review-requested
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In addition to adding the Teleport auth heartbeat_connections_received and teleport_roles metrics, this cleans up a few typos and updates Teleport image and tag used in the docker tests.
Motivation
Teleport customers are asking for the integration to be updated with all metrics exposed by Teleport: gravitational/teleport#50992.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged