-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keda integration Logs #19460
Keda integration Logs #19460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are quite a few places where we can refactor the grok expression to rely less on data
. This is highly recommended as expressions with many data
or expensive regexes might lead to the parsing being aborted if too inefficient.
Co-authored-by: Bruno Renier <[email protected]>
Co-authored-by: Bruno Renier <[email protected]>
Co-authored-by: Bruno Renier <[email protected]>
Co-authored-by: Bruno Renier <[email protected]>
Co-authored-by: Bruno Renier <[email protected]>
Co-authored-by: Bruno Renier <[email protected]>
@brunorenier Thanks for all the help so far! I really appreciate your input. I incorporated almost all of your suggestions, the only one I didn't I ended up dropping that rule and replacing it with something else. I think the only data matchers left are the ones for the keyvalues. Not sure if you have any ideas on how to address those. Thanks in advance and I do apologize for my shallow knowledge on the matter. |
Thanks for your patience and making all those changes! Those grok parser rules are really tricky and it's not obvious that using I'll deploy this integration to our staging env for a final check then approve. |
What does this PR do?
Logs pipeline for Keda
https://datadoghq.atlassian.net/browse/LOI-379