Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mongo] add service tag to agent operations #19456

Merged
merged 5 commits into from
Jan 22, 2025
Merged

[mongo] add service tag to agent operations #19456

merged 5 commits into from
Jan 22, 2025

Conversation

lu-zhengda
Copy link
Contributor

@lu-zhengda lu-zhengda commented Jan 22, 2025 •
edited
Loading

What does this PR do?

This PR adds the comment service='datadog-agent' to operations initiated by the MongoDB integration. The comment will be parsed by the DBM backend to accurately tag agent operations.

Motivation

To ensure all DBM agent integration operations are consistently and properly tagged with service='datadog-agent' for improved tracking and visibility.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@lu-zhengda lu-zhengda marked this pull request as ready for review January 22, 2025 17:32
@lu-zhengda lu-zhengda requested review from a team as code owners January 22, 2025 17:32
@lu-zhengda lu-zhengda added the qa/skip-qa Automatically skip this PR for the next QA label Jan 22, 2025
@lu-zhengda lu-zhengda changed the title [mongo] add DD_SERVICE to agent operations [mongo] add service tag to agent operations Jan 22, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.10526% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.09%. Comparing base (fd08ef9) to head (d385821).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
mongo 92.90% <92.10%> (-0.89%) ⬇️
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@lu-zhengda lu-zhengda added this pull request to the merge queue Jan 22, 2025
Merged via the queue into master with commit 6c5362e Jan 22, 2025
32 checks passed
@lu-zhengda lu-zhengda deleted the zhengda.lu/mongo-agent-service branch January 22, 2025 19:04
lu-zhengda added a commit that referenced this pull request Mar 5, 2025
@lu-zhengda
Revert "[mongo] add service tag to agent operations (#19456)"
eced633 
This reverts commit 6c5362e.
github-merge-queue bot pushed a commit that referenced this pull request Mar 5, 2025
@lu-zhengda
Revert "[mongo] add service tag to agent operations (#19456)" (#19768)
55b1c84 
* Revert "[mongo] add service tag to agent operations (#19456)"

This reverts commit 6c5362e.

* add changelog

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nenadnoveljic nenadnoveljic nenadnoveljic approved these changes

Assignees
No one assigned
Labels
agent/review-requested ecosystems/review-requested product/review-requested qa/skip-qa Automatically skip this PR for the next QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lu-zhengda @nenadnoveljic