Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mongo] include explain operations in samples #19450

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

lu-zhengda
Copy link
Contributor

@lu-zhengda lu-zhengda commented Jan 21, 2025

What does this PR do?

This PR adds support for capturing explain operations in MongoDB activity samples.

Motivation

Previously, explain operations were excluded from activity samples, which could result in an incomplete count of active database operations. Including them ensures more accurate tracking and representation of database activity.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.32%. Comparing base (bfbd8a7) to head (4c1ad4a).
Report is 8 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
mongo 93.07% <ø> (-0.73%) ⬇️
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@lu-zhengda lu-zhengda added this pull request to the merge queue Jan 22, 2025
Merged via the queue into master with commit b3da55a Jan 22, 2025
35 checks passed
@lu-zhengda lu-zhengda deleted the zhengda.lu/explain branch January 22, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants