Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Argo Workflow metrics #19447

Merged
merged 19 commits into from
Jan 23, 2025
Merged

Conversation

UTXOnly
Copy link
Contributor

@UTXOnly UTXOnly commented Jan 21, 2025

What does this PR do?

  • Add new Argo Workflow metrics added in v3.6+

Motivation

  • New metrics added in Argo Workflow 3.6+

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (b3da55a) to head (62c7624).
Report is 6 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
argo_workflows 89.61% <100.00%> (+1.37%) ⬆️
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@UTXOnly UTXOnly marked this pull request as ready for review January 22, 2025 18:34
@UTXOnly UTXOnly requested a review from a team as a code owner January 22, 2025 18:34
@steveny91 steveny91 added this pull request to the merge queue Jan 23, 2025
Merged via the queue into master with commit 35e3533 Jan 23, 2025
42 of 43 checks passed
@steveny91 steveny91 deleted the UTXOnly/argo-workflow-new-metrics branch January 23, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants