Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mongo] fix error CommandCursor is not subscriptable #19444

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

lu-zhengda
Copy link
Contributor

What does this PR do?

This PR fixes error CommandCursor is not subscriptable in replication oplog size and oplog window collection.

Motivation

https://datadoghq.atlassian.net/browse/DBMON-4927

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.76%. Comparing base (3585433) to head (cd7b604).
Report is 11 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
mongo 92.86% <100.00%> (-0.94%) ⬇️
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@lu-zhengda lu-zhengda added this pull request to the merge queue Jan 22, 2025
@lu-zhengda lu-zhengda added the qa/skip-qa Automatically skip this PR for the next QA label Jan 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2025
@lu-zhengda lu-zhengda added this pull request to the merge queue Jan 22, 2025
Merged via the queue into master with commit fd08ef9 Jan 22, 2025
41 checks passed
@lu-zhengda lu-zhengda deleted the zhengda.lu/oplog branch January 22, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants