-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDSaaS: Brevo: Monitor panel unfiltered #19436
DDSaaS: Brevo: Monitor panel unfiltered #19436
Conversation
…/integrations-core into brevo-assets-v1.0.0
…/integrations-core into brevo-assets-v1.0.0
…/integrations-core into brevo-assets-v1.0.0
…/integrations-core into brevo-assets-v1.0.0
…/integrations-core into brevo-assets-v1.0.0
@@ -31,7 +31,7 @@ | |||
"hide_zero_counts": true, | |||
"show_status": true, | |||
"last_triggered_format": "relative", | |||
"query": "tag:brevo $subject $recipient_email $sender_email $event_name", | |||
"query": "tag:brevo", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we expecting to query all logs with the tag brevo
even if this dashboard is only for transactional events? I think we might want source: brevo service:transactional_events
. The title is also Campaign Monitors Summary
so is there a tag we can query on for only Campaign Monitors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we have monitors only for transactional-events. Hence we have not added any more query.
What does this PR do?
PR contains the updated query of Monitor panel.
Motivation
NA
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged