Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDSaaS: Brevo: Monitor panel unfiltered #19436

Merged
merged 58 commits into from
Jan 27, 2025

Conversation

bparmar-crest
Copy link
Contributor

What does this PR do?

PR contains the updated query of Monitor panel.

Motivation

NA

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

bparmar-crest and others added 30 commits August 29, 2024 15:27
@@ -31,7 +31,7 @@
"hide_zero_counts": true,
"show_status": true,
"last_triggered_format": "relative",
"query": "tag:brevo $subject $recipient_email $sender_email $event_name",
"query": "tag:brevo",
Copy link
Contributor

@apiazza-dd apiazza-dd Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we expecting to query all logs with the tag brevo even if this dashboard is only for transactional events? I think we might want source: brevo service:transactional_events. The title is also Campaign Monitors Summary so is there a tag we can query on for only Campaign Monitors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we have monitors only for transactional-events. Hence we have not added any more query.

@apiazza-dd apiazza-dd self-requested a review January 20, 2025 16:25
@apiazza-dd apiazza-dd added this pull request to the merge queue Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.74%. Comparing base (6782bb7) to head (27f498a).
Report is 39 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Merged via the queue into DataDog:master with commit 6e6a5b9 Jan 27, 2025
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants