Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eci][oci] create oci oke OOTB dashboard #19373

Merged
merged 8 commits into from
Jan 30, 2025
Merged

[eci][oci] create oci oke OOTB dashboard #19373

merged 8 commits into from
Jan 30, 2025

Conversation

natwilkinson
Copy link
Contributor

@natwilkinson natwilkinson commented Jan 10, 2025

What does this PR do?

  • adds an OOTB dashboard for OCI OKE

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

iliakur
iliakur previously approved these changes Jan 14, 2025
Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but docs had some input.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.58%. Comparing base (bd8de59) to head (7aa1f2b).
Report is 28 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@temporal-github-worker-1 temporal-github-worker-1 bot dismissed iliakur’s stale review January 16, 2025 16:12

Stale Review dismissed by prbot

@natwilkinson
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 22, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-22 16:26:29 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-22 17:34:41 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@natwilkinson
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 22, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-22 17:28:59 UTC ❌ MergeQueue

PR already in the queue with status waiting

@natwilkinson
Copy link
Contributor Author

/remove

@dd-devflow
Copy link

dd-devflow bot commented Jan 22, 2025

Devflow running: /remove

View all feedbacks in Devflow UI.


2025-01-22 17:34:38 UTC ℹ️ Devflow: /remove

@natwilkinson
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 22, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-22 17:35:10 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-22 21:36:06 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@natwilkinson
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 30, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-30 18:32:01 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-30 19:32:24 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@natwilkinson
Copy link
Contributor Author

/remove

@dd-devflow
Copy link

dd-devflow bot commented Jan 30, 2025

Devflow running: /remove

View all feedbacks in Devflow UI.


2025-01-30 19:32:23 UTC ℹ️ Devflow: /remove

@sarah-witt sarah-witt added this pull request to the merge queue Jan 30, 2025
Merged via the queue into master with commit 191362a Jan 30, 2025
32 of 34 checks passed
@sarah-witt sarah-witt deleted the natalie/oke-ootbd branch January 30, 2025 20:31
github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
* create oci oke OOTB dashboard

* Update oke/assets/dashboards/oci_oke_overview.json

Co-authored-by: Jen Gilbert <[email protected]>

* Update oke/assets/dashboards/oci_oke_overview.json

Co-authored-by: Jen Gilbert <[email protected]>

* update title

* add template vars to dashboard

---------

Co-authored-by: Jen Gilbert <[email protected]> 191362a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants