Upgrade PGBouncer to psycopg3 #19325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
sethsamuel
commented
Dec 30, 2024
| @@ -73,47 +74,46 @@ def _collect_stats(self, db): | |||
| metric_scope.append(SERVERS_METRICS) | |||
|
|
|||
| try: | |||
| with db.cursor(cursor_factory=pgextras.DictCursor) as cursor: | |||
There was a problem hiding this comment.
PG3 with automatically starts a transaction, i.e., adds a BEGIN, which breaks many of the queries.
sethsamuel
changed the title
iliakur
previously approved these changes
Jan 22, 2025
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/review-requested
labels
…860-upgrade-psycopg-to-3-for-pgbouncer-integration
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…t works" This reverts commit 4df3963.
…th' into seth.samuel/DBMON-4860-upgrade-psycopg-to-3-for-pgbouncer-integration
…3-for-pgbouncer-integration
Kyle-Neale
approved these changes
Jan 23, 2025
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/review-requested
labels
sethsamuel
deleted the
seth.samuel/DBMON-4860-upgrade-psycopg-to-3-for-pgbouncer-integration
branch
github-actions bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
* WIP * WIP * v3 * Changelog * Use source * Comments * Binary * Build psycopg (#19326) * WIP * Merge fix * Dep * Fix license * WIP * WIP * Changelog * test * test * Version * Changelog * Always add bin path to $PATH on macos builders * Add a dummy change to test that a macos build with a cache hit works * Revert "Add a dummy change to test that a macos build with a cache hit works" This reverts commit 4df3963. --------- Co-authored-by: Alex Lopez <[email protected]> Co-authored-by: Alex Lopez <[email protected]> 5b65299
sethsamuel
added a commit
that referenced
this pull request
Jan 28, 2025
This reverts commit 5b65299.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
* Revert "Upgrade PGBouncer to psycopg3 (#19325)" This reverts commit 5b65299. * Changelog --------- Co-authored-by: Enrico Donnici <[email protected]>
datadog-agent-integrations-bot bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
* Revert "Upgrade PGBouncer to psycopg3 (#19325)" This reverts commit 5b65299. * Changelog --------- Co-authored-by: Enrico Donnici <[email protected]> (cherry picked from commit d6358fb)
sethsamuel
added a commit
that referenced
this pull request
Jan 28, 2025
* Revert "Upgrade PGBouncer to psycopg3 (#19325)" This reverts commit 5b65299. * Changelog --------- Co-authored-by: Enrico Donnici <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
* Revert "Upgrade PGBouncer to psycopg3 (#19325)" This reverts commit 5b65299. * Changelog --------- Co-authored-by: Enrico Donnici <[email protected]> d6358fb
iliakur
pushed a commit
that referenced
this pull request
Jan 28, 2025
* Revert "Update Posgres to psycopg3 (#19322)" This reverts commit b13f5e0. * Changelog * Dep * Revert "Upgrade PGBouncer to psycopg3" (#19497) * Revert "Upgrade PGBouncer to psycopg3 (#19325)" This reverts commit 5b65299. * Changelog --------- Co-authored-by: Enrico Donnici <[email protected]> --------- Co-authored-by: Enrico Donnici <[email protected]>
datadog-agent-integrations-bot bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
* Revert "Update Posgres to psycopg3 (#19322)" This reverts commit b13f5e0. * Changelog * Dep * Revert "Upgrade PGBouncer to psycopg3" (#19497) * Revert "Upgrade PGBouncer to psycopg3 (#19325)" This reverts commit 5b65299. * Changelog --------- Co-authored-by: Enrico Donnici <[email protected]> --------- Co-authored-by: Enrico Donnici <[email protected]> (cherry picked from commit a74f10a)
github-actions bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
* Revert "Update Posgres to psycopg3 (#19322)" This reverts commit b13f5e0. * Changelog * Dep * Revert "Upgrade PGBouncer to psycopg3" (#19497) * Revert "Upgrade PGBouncer to psycopg3 (#19325)" This reverts commit 5b65299. * Changelog --------- Co-authored-by: Enrico Donnici <[email protected]> --------- Co-authored-by: Enrico Donnici <[email protected]> a74f10a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates psycopg to 3 for the pgbouncer integration.
Motivation
psycopg2 is deprecated and hasn't been updated in quite some time.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged