Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Posgres to psycopg3 #19322

Merged
merged 15 commits into from
Jan 22, 2025
Merged

Update Posgres to psycopg3 #19322

merged 15 commits into from
Jan 22, 2025

Conversation

sethsamuel
Copy link
Contributor

@sethsamuel sethsamuel commented Dec 27, 2024

What does this PR do?

Upgrades psycopg to version 3 for Postgres integration.

DBMON-4859

Motivation

psycopg2 is deprecated and has not been updated in quite some time.

Review checklist (to be filled by reviewers)

The previous attempt at this upgrade caused problems in the Datadog cluster agents. This will need to be tested in staging extensively during RC.

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 14 lines in your changes missing coverage. Please review.

Project coverage is 87.80%. Comparing base (58e21f7) to head (ee3b3df).
Report is 5 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
duckdb ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
octopus_deploy ?
postgres 93.42% <94.11%> (+4.14%) ⬆️
presto ?
solr ?
supabase ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@sethsamuel sethsamuel changed the title Update to psycopg3 Update Posgres to psycopg3 Dec 30, 2024
@sethsamuel sethsamuel marked this pull request as ready for review January 22, 2025 17:24
@sethsamuel sethsamuel requested review from a team as code owners January 22, 2025 17:24
Merged via the queue into master with commit b13f5e0 Jan 22, 2025
48 of 49 checks passed
@sethsamuel sethsamuel deleted the seth.samuel/psycopg3 branch January 22, 2025 20:43
github-actions bot pushed a commit that referenced this pull request Jan 22, 2025
* WIP

* WIP

* Changelog

* Changelog

* Dep

* License

* License

* Lint

* Fix

* Build deps

* E2E

* Lint

* +x b13f5e0
sethsamuel added a commit that referenced this pull request Jan 28, 2025
iliakur pushed a commit that referenced this pull request Jan 28, 2025
* Revert "Update Posgres to psycopg3 (#19322)"

This reverts commit b13f5e0.

* Changelog

* Dep

* Revert "Upgrade PGBouncer to psycopg3" (#19497)

* Revert "Upgrade PGBouncer to psycopg3 (#19325)"

This reverts commit 5b65299.

* Changelog

---------

Co-authored-by: Enrico Donnici <[email protected]>

---------

Co-authored-by: Enrico Donnici <[email protected]>
datadog-agent-integrations-bot bot pushed a commit that referenced this pull request Jan 28, 2025
* Revert "Update Posgres to psycopg3 (#19322)"

This reverts commit b13f5e0.

* Changelog

* Dep

* Revert "Upgrade PGBouncer to psycopg3" (#19497)

* Revert "Upgrade PGBouncer to psycopg3 (#19325)"

This reverts commit 5b65299.

* Changelog

---------

Co-authored-by: Enrico Donnici <[email protected]>

---------

Co-authored-by: Enrico Donnici <[email protected]>
(cherry picked from commit a74f10a)
github-actions bot pushed a commit that referenced this pull request Jan 28, 2025
* Revert "Update Posgres to psycopg3 (#19322)"

This reverts commit b13f5e0.

* Changelog

* Dep

* Revert "Upgrade PGBouncer to psycopg3" (#19497)

* Revert "Upgrade PGBouncer to psycopg3 (#19325)"

This reverts commit 5b65299.

* Changelog

---------

Co-authored-by: Enrico Donnici <[email protected]>

---------

Co-authored-by: Enrico Donnici <[email protected]> a74f10a
nubtron added a commit that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants