[AI-4595] DDS: Keycloak Integration V1.0.0 #19019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datadog-agent-integrations-bot
bot
added
documentation
dev/testing
dev/tooling
release
qa/skip-qa
|
Created Jira card for Docs Team editorial review. |
drichards-87
added
the
editorial review
|
@thibaultkrebs 👋 could you take a peek at this again, it looks like your comment was addressed. |
audesikorav
reviewed
Jan 13, 2025
There was a problem hiding this comment.
I see you don't use any date-remapper, this will results in a generated timestamp when the logs is received (doc). Are you sure you want that ?
otherwise I'll approve the PR
|
@audesikorav Regarding your this comment, |
audesikorav
previously approved these changes
Jan 20, 2025
temporal-github-worker-1
bot
added
agent/requested-changes
and removed
agent/review-requested
labels
temporal-github-worker-1
bot
dismissed
aliciascott’s stale review
Stale Review dismissed by prbot
temporal-github-worker-1
bot
added
docs/requested-changes
and removed
docs/approved
labels
temporal-github-worker-1
bot
added
docs/review-requested
and removed
docs/requested-changes
labels
iliakur
previously approved these changes
Jan 29, 2025
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/requested-changes
labels
temporal-github-worker-1
bot
added
agent/review-requested
and removed
agent/approved
labels
iliakur
approved these changes
Feb 3, 2025
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/review-requested
labels
github-actions bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
* Add: keycloak Integration * Update: manifest and changelog.d for CI checks * Update: manifest.json * Test pipeline log parsing for CI * test different sample * Test log without message field * Revert pipeline sample testing log * Update: grok parser and readme minor description * Update: description in dashboard * Update: replace sample with CI pipeline formatted sample * Update: Format as per comment * Update: Address review comments on 29/11/2024 * Update: test samples with only message attribute. * Update: add results from pipeline * Update: address review comments and update __init__.py and __about__.py --------- Co-authored-by: Ilia Kurenkov <[email protected]> f223704
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR for a new integration Keycloak 1.0.0
Additional Notes
-- OOTB detection rules JSON would be shared separately with the required teams as a part of separate repository .
-- Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current datadog behavior.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged