Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTPLAT-457] DDSaaS: Postmark: Integration v1.0.0 #18898

Merged
merged 24 commits into from
Jan 22, 2025
Merged

[INTPLAT-457] DDSaaS: Postmark: Integration v1.0.0 #18898

merged 24 commits into from
Jan 22, 2025

Conversation

bparmar-crest
Copy link
Contributor

What does this PR do?

This is a initial release PR of Postmark integration including all the required assets i.e. Pipeline, Dashboard and Monitors.

Additional Notes

  • This integration is webhook based and Crawler will not be used.
  • Datadog team will be required to add UI component for generation of webhook URL in the configuration tile. The ddsource query param should be 'postmark'.
  • The assets are available in our sandbox and can be shared separately with the required teams.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@bparmar-crest bparmar-crest marked this pull request as ready for review October 23, 2024 14:18
@bparmar-crest bparmar-crest requested a review from a team as a code owner October 23, 2024 14:18
@bparmar-crest bparmar-crest requested a review from a team October 23, 2024 14:18
@bparmar-crest bparmar-crest requested review from a team as code owners October 23, 2024 14:18
@rtrieu
Copy link
Contributor

rtrieu commented Oct 23, 2024

Created DOCS-9334 for editorial review.

@rtrieu rtrieu added the editorial review Waiting on a more in-depth review from a docs team editor label Oct 23, 2024
@torosmassa torosmassa changed the title DDSaaS: Postmark: Integration v1.0.0 [SAASINT-3219] DDSaaS: Postmark: Integration v1.0.0 Oct 25, 2024
estherk15
estherk15 reviewed Oct 29, 2024
View reviewed changes
estherk15
estherk15 previously approved these changes Nov 5, 2024
View reviewed changes
@bparmar-crest bparmar-crest dismissed stale reviews from estherk15 and brunorenier via b4d1fbb December 23, 2024 09:47
iliakur
iliakur previously approved these changes Jan 8, 2025
View reviewed changes
brunorenier
brunorenier approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@brunorenier brunorenier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving for logs since I don't see any change since my earlier review.

@Wyrine Wyrine requested a review from a team January 14, 2025 16:37
michaelcretzman
michaelcretzman requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@michaelcretzman michaelcretzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested

@temporal-github-worker-1 temporal-github-worker-1 bot dismissed iliakur’s stale review January 16, 2025 07:14

Stale Review dismissed by prbot

@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.52%. Comparing base (5dc1c5c) to head (a85eb3b).
Report is 30 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@Wyrine Wyrine enabled auto-merge January 22, 2025 20:58
@Wyrine Wyrine added this pull request to the merge queue Jan 22, 2025
Merged via the queue into DataDog:master with commit 22c0eeb Jan 22, 2025
40 of 41 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 22, 2025
@github-merge-queue
[INTPLAT-457] DDSaaS: Postmark: Integration v1.0.0 (#18898)
0b03465 
* Project skeleton for Postmark

* Postmark assets v1.0.0

* CI assets fixed

* review comments incorporated

* README statement corrected

* Integration names removed from Monitors

* Monitors name modified in manifest.json

* CODEOWNERS

* README.md modified

* Update postmark.yaml

* Update postmark.yaml

* README changes

* review changes incorporated

---------

Co-authored-by: rajshah-crest <[email protected]> 22c0eeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajshah-crest rajshah-crest rajshah-crest left review comments

@iliakur iliakur iliakur approved these changes

@dpoint01 dpoint01 dpoint01 approved these changes

@estherk15 estherk15 estherk15 approved these changes

@michaelcretzman michaelcretzman michaelcretzman approved these changes

@brunorenier brunorenier brunorenier approved these changes

Assignees
No one assigned
Labels
agent/approved assets/deploy-logs-staging ONLY USED BY Logs Backend - Validates that a PR is OK to go to staging changelog/no-changelog dev/testing dev/tooling docs/approved documentation ecosystems/review-requested editorial review Waiting on a more in-depth review from a docs team editor product/review-requested qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations team/documentation team/logs-backend team/siem-logs-reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bparmar-crest @rtrieu @iliakur @dpoint01 @estherk15 @michaelcretzman @brunorenier @rajshah-crest @Wyrine