Skip to content

Fix: Return 400 for template validation errors instead of 500 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 2 commits into from
Aug 19, 2026
Merged

Fix: Return 400 for template validation errors instead of 500 #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe0e271
Fix: Return 400 for template validation errors instead of 500
dengkliu92 Aug 19, 2026
1bc1e36
Potential fix for pull request finding
dengkliu92 Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/llm/src/preprocessor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1095,7 +1095,15 @@ impl OpenAIPreprocessor {
let formatted_prompt = {
let _nvtx = dynamo_nvtx_range!("preprocess.template");
self.apply_template(request)
.with_context(|| "Failed to apply prompt template")?
.map_err(|e| {
let msg = format!("Failed to apply prompt template: {e}");
DynamoError::builder()
.error_type(ErrorType::InvalidArgument)
.message(msg)
.cause(e)
.build()
.into()
})?
Comment thread
Copilot marked this conversation as resolved.
};
TEMPLATE_SECONDS.observe(template_start.elapsed().as_secs_f64());

Expand Down
Loading