Skip to content

Conversation

@HantingZhang2
Copy link
Contributor

@HantingZhang2 HantingZhang2 commented Dec 22, 2025

What does this PR do? What is the motivation?

Note that the global variable names will be visible.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@HantingZhang2 HantingZhang2 requested a review from a team as a code owner December 22, 2025 16:33
@brett0000FF brett0000FF self-assigned this Dec 22, 2025
@github-actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight edit to your addition. Let me know what you think!

| Viewer | {{< X >}} | {{< X >}} | {{< X >}} | |
| Editor | {{< X >}} | {{< X >}} | {{< X >}} | {{< X >}} |

Restricting a variable prevents other users from adding it to a test and using it, but they are still able to see the variable name if it was added to a test by an authorized user.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Restricting a variable prevents other users from adding it to a test and using it, but they are still able to see the variable name if it was added to a test by an authorized user.
**Note**: Restricting a variable only limits its usage in new tests; it does not hide the name of the variable if it is already active in an existing test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brett0000FF

Restricting a variable only limits its usage in new tests;

This is not accurate, users cannot edit a test containing a Synthetics global variable they do not have access to either

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted, thank you for the clarification. 👍

@brett0000FF brett0000FF merged commit 5d7f165 into master Dec 24, 2025
23 of 26 checks passed
@brett0000FF brett0000FF deleted the hzhang/Update-GV-documentation-to-note-restricted-GV-names-are-not-hidden- branch December 24, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants