-
Notifications
You must be signed in to change notification settings - Fork 1.2k
PR Gates - new product flow [DOCS-10684] #30713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: joepeeples/10684-pr-gates
Are you sure you want to change the base?
PR Gates - new product flow [DOCS-10684] #30713
Conversation
Smol change for testing, open PR
ℹ️ Documentation Team ReviewNo documentation team review is required for this pull request. |
Preview links (active after the
|
no Explorer view currently
Search not currently available, and no longer enough content to justify having a separate Manage page. Also adds redirect alias for the removed page.
The "Executions" page in the app no longer exists, so links to it will 404. For now I'm just changing to the main PR Gates app page to avoid breaks, and we'll remove the full Explorer content & links in #30713
…es-new-product-flow
forgot to save
…es-new-product-flow
…es-new-product-flow
…es-new-product-flow
Audit Trail does not seem supported yet for PR Gates
Opened DOCS-11772 for editorial review. |
…es-new-product-flow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Approving the PR. I just had one small suggestion and a comment re: a product name.
content/en/pr_gates/_index.md
Outdated
| [**Static Code Analysis**][11] | <li> Code vulnerability violations <li> Code quality violations | | ||
| [**Software Composition Analysis**][12] | <li> Library vulnerability violations <li> Detected license violations | | ||
| [**Code Coverage**][15] | <li> Total code coverage threshold <li> Patch code coverage threshold | | ||
| [**Infrastructure as Code Scanning**][16] | <li> IaC vulnerability severity | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting that we recently changed the name to Infrastructure as Code Security. But it looks like the UI still refers to it as Infrastructure as Code Scanning. Could we pass this feedback along to the PR Gates PM?
Co-authored-by: Mark Azer <[email protected]>
Co-authored-by: DeForest Richards <[email protected]>
Co-authored-by: Mark Azer <[email protected]>
…es-new-product-flow
What does this PR do? What is the motivation?
Revises documentation for new PR Gates product.
Important
This PR builds on and targets the product renaming branch in #29089. When we're ready to merge, we need to merge the renaming PR first, then rebase this PR to
main
. This shouldn't affect any content being reviewed in the current PR.Tip
For reviewers: Because of extensive revisions to multiple sections, the diff tab in GitHub looks pretty choppy and isn't great for reviewing. It's probably easier to review the preview as a whole, focusing on the main landing page and Setup page.
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes