Skip to content

Add AWS file to docs repo Vale ini #30494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

janine-c
Copy link
Contributor

What does this PR do? What is the motivation?

Follow-up to DataDog/datadog-vale#72. If that PR gets merged, then this one can also get merged so we can use the new rules in the docs repo.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@janine-c janine-c requested a review from a team as a code owner July 15, 2025 20:38
Copy link
Contributor

github-actions bot commented Jul 15, 2025

✅ Documentation Team Review

The documentation team has approved this pull request. Thank you for your contribution!

@janine-c
Copy link
Contributor Author

Shh, dutiful preview builder. Worry not your pretty little processor over building that which cannot be built.

Copy link
Contributor

@iadjivon iadjivon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Janine, approving this PR, but leaving the Vale one for someone with a bit more expertise than I. Thanks for your improvements of our processes! 👏

@janine-c
Copy link
Contributor Author

Thanks for taking a look, @iadjivon!!

@janine-c janine-c added the editorial review Waiting on a more in-depth review label Jul 15, 2025
@janine-c janine-c merged commit b6d4361 into master Jul 16, 2025
21 of 22 checks passed
@janine-c janine-c deleted the janine.chan/aws-substitutions-vale-ini branch July 16, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review Waiting on a more in-depth review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants