Skip to content

Serverless > Azure App Services Linux > Update .NET instructions #30470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

lucaspimentel
Copy link
Member

@lucaspimentel lucaspimentel commented Jul 14, 2025

What does this PR do? What is the motivation?

The main motivation was:

  • Fix the value for CORECLR_PROFILER_PATH environment variable (was wrong and would not work for most users)
  • Clean up installation instructions for .NET tracer

While I was in here:

  • Fix a broken URL
  • Bonus: fix Node => Node.js (branding is important 😉)

(Edit) After some PR feedback:

  • reordered, removed, and cleaned up more all links
  • switched from tables to lists for the env vars to improve readability

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

Copy link
Contributor

github-actions bot commented Jul 14, 2025

📝 Documentation Team Review Required

This pull request requires approval from the @DataDog/documentation team before it can be merged.

Please ensure your changes follow our documentation guidelines and wait for a team member to review and approve your changes.

Copy link
Contributor

@lucaspimentel lucaspimentel changed the title Serverless > Azure App Services > .NET: Update installation instructions Serverless > Azure App Services Linux > .NET: Update installation instructions Jul 14, 2025
@lucaspimentel lucaspimentel marked this pull request as ready for review July 14, 2025 22:38
@lucaspimentel lucaspimentel requested review from a team as code owners July 14, 2025 22:38
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@iadjivon iadjivon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!
Some of the links lead to the incorrect page/section. Kindly let us know once this is fixed. Thanks!

@lucaspimentel lucaspimentel changed the title Serverless > Azure App Services Linux > .NET: Update installation instructions Serverless > Azure App Services Linux > Update .NET instructions Jul 15, 2025
| Linux | Node.js | [Linux Node.js setup][12] |
| Linux | PHP | [Linux PHP setup][13] |
| Linux | Python | [Linux Python setup][14] |
| Linux | Container | [Linux Container setup][15] |
Copy link
Member Author

@lucaspimentel lucaspimentel Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This table splits "Windows" and "Linux" into individual languages, but not "Linux Container". For consistency, should we have only 3 rows?

  • Windows
  • Linux
  • Linux Container

or should we also split "Container" into individual languages? Do we care? 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this change (if we went to do this) for another PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i could definitely see three rows being much simpler down the road, but i agree its probably better to leave for a future PR

@lucaspimentel lucaspimentel requested a review from iadjivon July 16, 2025 20:45
@lucaspimentel
Copy link
Member Author

Some of the links lead to the incorrect page/section. Kindly let us know once this is fixed. Thanks!

Thanks, @iadjivon. All the links should be fixed now.

| Linux | Node.js | [Linux Node.js setup][12] |
| Linux | PHP | [Linux PHP setup][13] |
| Linux | Python | [Linux Python setup][14] |
| Linux | Container | [Linux Container setup][15] |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i could definitely see three rows being much simpler down the road, but i agree its probably better to leave for a future PR

Comment on lines 187 to 194
`CORECLR_PROFILER_PATH`
: **Value for glibc-based Linux distros**:<br>
`/home/site/wwwroot/datadog/`<br>
`linux-x64/Datadog.Trace.ClrProfiler.Native.so`<br>
**Value for Alpine Linux and other musl-based distros**:<br>
`/home/site/wwwroot/datadog/`<br>
`linux-musl-x64/Datadog.Trace.ClrProfiler.Native.so`<br>
Path to the instrumentation library loaded by the .NET runtime.<br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is for linux code, we should only show the glibc version. instead, we should add the musl option to the linux container .net section

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GAS Serverless GCP & Azure serverless
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants