-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Serverless > Azure App Services Linux > Update .NET instructions #30470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Serverless > Azure App Services Linux > Update .NET instructions #30470
Conversation
📝 Documentation Team Review RequiredThis pull request requires approval from the @DataDog/documentation team before it can be merged. Please ensure your changes follow our documentation guidelines and wait for a team member to review and approve your changes. |
Preview links (active after the
|
content/en/serverless/azure_app_services/azure_app_services_linux.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
content/en/serverless/azure_app_services/azure_app_services_linux.md
Outdated
Show resolved
Hide resolved
content/en/serverless/azure_app_services/azure_app_services_linux.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there!
Some of the links lead to the incorrect page/section. Kindly let us know once this is fixed. Thanks!
| Linux | Node.js | [Linux Node.js setup][12] | | ||
| Linux | PHP | [Linux PHP setup][13] | | ||
| Linux | Python | [Linux Python setup][14] | | ||
| Linux | Container | [Linux Container setup][15] | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This table splits "Windows" and "Linux" into individual languages, but not "Linux Container". For consistency, should we have only 3 rows?
- Windows
- Linux
- Linux Container
or should we also split "Container" into individual languages? Do we care? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave this change (if we went to do this) for another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i could definitely see three rows being much simpler down the road, but i agree its probably better to leave for a future PR
Thanks, @iadjivon. All the links should be fixed now. |
Co-authored-by: Andrew Lock <[email protected]>
99a8655
to
c77a89b
Compare
| Linux | Node.js | [Linux Node.js setup][12] | | ||
| Linux | PHP | [Linux PHP setup][13] | | ||
| Linux | Python | [Linux Python setup][14] | | ||
| Linux | Container | [Linux Container setup][15] | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i could definitely see three rows being much simpler down the road, but i agree its probably better to leave for a future PR
`CORECLR_PROFILER_PATH` | ||
: **Value for glibc-based Linux distros**:<br> | ||
`/home/site/wwwroot/datadog/`<br> | ||
`linux-x64/Datadog.Trace.ClrProfiler.Native.so`<br> | ||
**Value for Alpine Linux and other musl-based distros**:<br> | ||
`/home/site/wwwroot/datadog/`<br> | ||
`linux-musl-x64/Datadog.Trace.ClrProfiler.Native.so`<br> | ||
Path to the instrumentation library loaded by the .NET runtime.<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is for linux code, we should only show the glibc version. instead, we should add the musl option to the linux container .net section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, thanks!
What does this PR do? What is the motivation?
The main motivation was:
CORECLR_PROFILER_PATH
environment variable (was wrong and would not work for most users)While I was in here:
Node
=>Node.js
(branding is important 😉)(Edit) After some PR feedback:
moreall linksMerge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes