Skip to content

Auto instrumentation updates v2 #28766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dd-mergequeue merged 7 commits into from
Apr 23, 2025
Merged

Auto instrumentation updates v2 #28766

dd-mergequeue merged 7 commits into from
Apr 23, 2025

Conversation

@rtrieu
Copy link
Contributor

@rtrieu rtrieu commented Apr 14, 2025

What does this PR do? What is the motivation?

  • Updates the RUM Auto-Instrumentation docs based on PM feedback:
    • Moves the limitation details from individual web servers to main page
    • Moves remote config steps from individual web servers to main page
    • Adds a sentence for motivation for manually loading module onto web servers

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@rtrieu rtrieu requested review from a team as code owners April 14, 2025 20:27
@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025

Preview links (active after the build_preview check completes)

Modified Files

joepeeples
joepeeples approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small edit suggestions, LGTM!

@rtrieu
Copy link
Contributor Author

rtrieu commented Apr 22, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 22, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-22 18:56:25 UTC ℹ️ Start processing command /merge

2025-04-22 18:56:30 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-04-22 22:57:04 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@rtrieu
Copy link
Contributor Author

rtrieu commented Apr 23, 2025

/merge -c

@dd-devflow
Copy link

dd-devflow bot commented Apr 23, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-23 17:35:06 UTC ℹ️ Start processing command /merge -c
If you need support, contact us on Slack #devflow!

2025-04-23 17:35:09 UTC ❌ Devflow: /merge -c

This merge request was already processed and can't be unqueued anymore.

To get help about command usage, write /merge --help

If you need support, contact us on Slack #devflow with those details!

@rtrieu
Copy link
Contributor Author

rtrieu commented Apr 23, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 23, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-23 18:32:45 UTC ℹ️ Start processing command /merge

2025-04-23 18:32:48 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 18m (p90).

2025-04-23 18:48:38 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 04583cf into master Apr 23, 2025
16 of 18 checks passed
@dd-mergequeue dd-mergequeue bot deleted the rtrieu/auto-instrumentation-updates-v2 branch April 23, 2025 18:48
estherk15 pushed a commit that referenced this pull request May 8, 2025
@rtrieu @joepeeples
@BenoitZugmeyer @estherk15
Auto instrumentation updates v2 (#28766)
a34b9bd 
* move limitations around and add further reading

* move limitations and add more descriptions

* Apply suggestions from code review

Co-authored-by: Joe Peeples <[email protected]>

* Apply suggestions from code review

Co-authored-by: Benoît <[email protected]>

---------

Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Benoît <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenoitZugmeyer BenoitZugmeyer BenoitZugmeyer left review comments

@joepeeples joepeeples joepeeples approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rtrieu @BenoitZugmeyer @joepeeples