Generate metrics for GraphQL operation execution #4862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for updating Change log entry section 👏 Visited at: 2025-08-19 22:52:31 UTC |
BenchmarksBenchmark execution time: 2025-08-19 23:21:01 Comparing candidate commit b4e1ba9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4862 +/- ##
==========================================
- Coverage 97.55% 97.54% -0.02%
==========================================
Files 1507 1507
Lines 89763 89770 +7
Branches 4753 4755 +2
==========================================
- Hits 87567 87564 -3
- Misses 2196 2206 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
y9v
approved these changes
Aug 20, 2025
p-datadog
reviewed
Aug 20, 2025
| lambda { |span| | ||
| # Ensure this span can be aggregated by in the Datadog App, and generates RED metrics. | ||
| span.set_tag(Tracing::Metadata::Ext::TAG_KIND, Tracing::Metadata::Ext::SpanKind::TAG_SERVER) | ||
| span.set_tag('span.kind', 'server') |
There was a problem hiding this comment.
Are these two lines doing the same thing?
Strech
approved these changes
Sep 1, 2025
vpellan
approved these changes
Sep 2, 2025
|
LGTM, beside the duplicate tag ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the span responsible for generating service page metrics to the
graphql.executespan, which represents a single GraphQL operation execution.This allows for toggling the APM service service page between, for example,
rack.requestandgraphql.execute.The default today is to prioritize
graphql.executeas the primary operation, but this wasn't working for Ruby because there were no metrics to populate the the service page with. This PR fixes that.The service page will look something like this, with GraphQL operations in the
Resourcestab (instead ofPOST /graphql):This PR also a changes in the resource name for the
graphql.execute, from just the operation name (simpleQuery) to operation type + operation name (query simpleQuery). This aligns closely with the desired grouping pattern for GraphQL operations, and prevents conflicts when a mutation and query have the same name.This is a non-breaking change because the
graphql.executespan could not be monitored on, since there were no metrics generated for it (we won't be able to change it this easily anymore 🙂).Change log entry
Yes. * Added: Generate metrics for GraphQL operation execution. * Changed: The
graphql.executespan resource now includes the operation type.