- 
                Notifications
    You must be signed in to change notification settings 
- Fork 468
chore(env_proxy): move env proxy constants to the correct namespace #15064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| 
  | 
| Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 237 ± 3 ms. The average import time from base is: 238 ± 2 ms. The import time difference between this PR and base is: -1.5 ± 0.1 ms. Import time breakdownThe following import paths have shrunk: 
             | 
| Performance SLOsComparing candidate avara/refactor_env_proxy (3f0fcdf) with baseline main (9c2acd7) 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.981µs (SLO: <10.000µs 📉 -50.2%) vs baseline: 📈 +19.6% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% ✅ ospathbasename_noaspectTime: ✅ 1.093µs (SLO: <10.000µs 📉 -89.1%) vs baseline: +1.0% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ ospathjoin_aspectTime: ✅ 7.078µs (SLO: <10.000µs 📉 -29.2%) vs baseline: 📈 +15.3% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ ospathjoin_noaspectTime: ✅ 2.299µs (SLO: <10.000µs 📉 -77.0%) vs baseline: -0.8% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ ospathnormcase_aspectTime: ✅ 3.852µs (SLO: <10.000µs 📉 -61.5%) vs baseline: 📈 +11.5% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ ospathnormcase_noaspectTime: ✅ 0.567µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.1% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 5.715µs (SLO: <10.000µs 📉 -42.8%) vs baseline: 📈 +18.4% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.8% ✅ ospathsplit_noaspectTime: ✅ 1.604µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +0.7% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ ospathsplitdrive_aspectTime: ✅ 3.664µs (SLO: <10.000µs 📉 -63.4%) vs baseline: -1.1% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ ospathsplitdrive_noaspectTime: ✅ 0.708µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +2.3% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 4.590µs (SLO: <10.000µs 📉 -54.1%) vs baseline: +1.2% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ ospathsplitext_noaspectTime: ✅ 1.375µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -1.1% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% 🟡 Near SLO Breach (6 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.482ms (SLO: <22.300ms -8.2%) vs baseline: -0.5% Memory: ✅ 66.407MB (SLO: <67.000MB 🟡 -0.9%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.345ms (SLO: <1.450ms -7.2%) vs baseline: +0.6% Memory: ✅ 64.663MB (SLO: <67.000MB -3.5%) vs baseline: +5.0% ✅ iastTime: ✅ 20.488ms (SLO: <22.250ms -7.9%) vs baseline: +0.1% Memory: ✅ 66.465MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.9% ✅ profilerTime: ✅ 15.443ms (SLO: <16.550ms -6.7%) vs baseline: -0.4% Memory: ✅ 54.126MB (SLO: <54.500MB 🟡 -0.7%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 20.551ms (SLO: <21.750ms -5.5%) vs baseline: ~same Memory: ✅ 66.505MB (SLO: <67.000MB 🟡 -0.7%) vs baseline: +5.0% ✅ span-code-originTime: ✅ 25.398ms (SLO: <28.200ms -9.9%) vs baseline: +0.1% Memory: ✅ 67.407MB (SLO: <69.500MB -3.0%) vs baseline: +4.6% ✅ tracerTime: ✅ 20.501ms (SLO: <21.750ms -5.7%) vs baseline: -0.2% Memory: ✅ 66.431MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 22.699ms (SLO: <23.500ms -3.4%) vs baseline: +0.3% Memory: ✅ 67.751MB (SLO: <68.000MB 🟡 -0.4%) vs baseline: +4.7% ✅ tracer-dont-create-db-spansTime: ✅ 19.304ms (SLO: <21.500ms 📉 -10.2%) vs baseline: ~same Memory: ✅ 66.434MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.8% ✅ tracer-minimalTime: ✅ 16.641ms (SLO: <17.500ms -4.9%) vs baseline: +0.2% Memory: ✅ 66.492MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +5.0% ✅ tracer-nativeTime: ✅ 20.551ms (SLO: <21.750ms -5.5%) vs baseline: +0.4% Memory: ✅ 72.155MB (SLO: <72.500MB 🟡 -0.5%) vs baseline: +4.7% ✅ tracer-no-cachesTime: ✅ 18.531ms (SLO: <19.650ms -5.7%) vs baseline: +0.4% Memory: ✅ 66.450MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.728ms (SLO: <20.100ms -6.8%) vs baseline: -0.3% Memory: ✅ 66.472MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.8% ✅ tracer-no-middlewareTime: ✅ 20.155ms (SLO: <21.500ms -6.3%) vs baseline: +0.1% Memory: ✅ 66.453MB (SLO: <67.000MB 🟡 -0.8%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.318ms (SLO: <22.000ms -7.6%) vs baseline: +0.2% Memory: ✅ 66.388MB (SLO: <67.000MB 🟡 -0.9%) vs baseline: +4.8% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.140ms (SLO: <19.850ms -8.6%) vs baseline: +0.4% Memory: ✅ 66.446MB (SLO: <66.500MB 🟡 ~same) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.193ms (SLO: <19.400ms -6.2%) vs baseline: +0.5% Memory: ✅ 66.525MB (SLO: <66.500MB ~same) vs baseline: +5.0% ✅ tracer-enabledTime: ✅ 18.134ms (SLO: <19.450ms -6.8%) vs baseline: +0.1% Memory: ✅ 66.349MB (SLO: <66.500MB 🟡 -0.2%) vs baseline: +4.8% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.071ms (SLO: <2.300ms -10.0%) vs baseline: -0.3% Memory: ✅ 52.907MB (SLO: <53.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ errortracking-enabled-userTime: ✅ 2.075ms (SLO: <2.250ms -7.8%) vs baseline: ~same Memory: ✅ 52.868MB (SLO: <53.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 2.089ms (SLO: <2.300ms -9.2%) vs baseline: +0.4% Memory: ✅ 52.789MB (SLO: <53.500MB 🟡 -1.3%) vs baseline: +4.7% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.587ms (SLO: <4.750ms -3.4%) vs baseline: -0.2% Memory: ✅ 62.659MB (SLO: <65.000MB -3.6%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 6.626ms (SLO: <6.750ms 🟡 -1.8%) vs baseline: -0.1% Memory: ✅ 62.816MB (SLO: <65.000MB -3.4%) vs baseline: +5.0% ✅ appsec-telemetryTime: ✅ 4.594ms (SLO: <4.750ms -3.3%) vs baseline: ~same Memory: ✅ 62.738MB (SLO: <65.000MB -3.5%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.859ms (SLO: <2.000ms -7.0%) vs baseline: +0.4% Memory: ✅ 45.318MB (SLO: <47.000MB -3.6%) vs baseline: +4.6% ✅ iast-getTime: ✅ 1.855ms (SLO: <2.000ms -7.2%) vs baseline: ~same Memory: ✅ 42.408MB (SLO: <49.000MB 📉 -13.5%) vs baseline: +4.9% ✅ profilerTime: ✅ 1.917ms (SLO: <2.100ms -8.7%) vs baseline: -0.1% Memory: ✅ 46.439MB (SLO: <47.000MB 🟡 -1.2%) vs baseline: +4.2% ✅ resource-renamingTime: ✅ 3.365ms (SLO: <3.650ms -7.8%) vs baseline: -0.2% Memory: ✅ 53.006MB (SLO: <53.500MB 🟡 -0.9%) vs baseline: +4.8% ✅ tracerTime: ✅ 3.358ms (SLO: <3.650ms -8.0%) vs baseline: +0.2% Memory: ✅ 52.986MB (SLO: <53.500MB 🟡 -1.0%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.360ms (SLO: <3.650ms -7.9%) vs baseline: +0.2% Memory: ✅ 58.887MB (SLO: <60.000MB 🟡 -1.9%) vs baseline: +4.8% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.962ms (SLO: <4.200ms -5.7%) vs baseline: -0.3% Memory: ✅ 63.092MB (SLO: <66.000MB -4.4%) vs baseline: +5.1% ✅ iast-enabledTime: ✅ 2.428ms (SLO: <2.800ms 📉 -13.3%) vs baseline: -0.4% Memory: ✅ 59.435MB (SLO: <60.000MB 🟡 -0.9%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 2.069ms (SLO: <2.250ms -8.0%) vs baseline: +0.4% Memory: ✅ 53.064MB (SLO: <54.500MB -2.6%) vs baseline: +5.1% 🟡 packagesupdateimporteddependencies - 24/24✅ import_manyTime: ✅ 155.770µs (SLO: <170.000µs -8.4%) vs baseline: +0.5% Memory: ✅ 36.892MB (SLO: <38.500MB -4.2%) vs baseline: +4.2% ✅ import_many_cachedTime: ✅ 121.632µs (SLO: <130.000µs -6.4%) vs baseline: ~same Memory: ✅ 37.031MB (SLO: <38.500MB -3.8%) vs baseline: +4.9% ✅ import_many_stdlibTime: ✅ 1.619ms (SLO: <1.750ms -7.5%) vs baseline: -0.6% Memory: ✅ 37.461MB (SLO: <38.500MB -2.7%) vs baseline: +5.6% ✅ import_many_stdlib_cachedTime: ✅ 0.974ms (SLO: <1.100ms 📉 -11.4%) vs baseline: ~same Memory: ✅ 37.510MB (SLO: <38.500MB -2.6%) vs baseline: +4.8% ✅ import_many_unknownTime: ✅ 838.434µs (SLO: <890.000µs -5.8%) vs baseline: -0.3% Memory: ✅ 37.799MB (SLO: <38.500MB 🟡 -1.8%) vs baseline: +5.8% ✅ import_many_unknown_cachedTime: ✅ 796.163µs (SLO: <870.000µs -8.5%) vs baseline: ~same Memory: ✅ 37.528MB (SLO: <38.500MB -2.5%) vs baseline: +6.0% ✅ import_oneTime: ✅ 19.864µs (SLO: <30.000µs 📉 -33.8%) vs baseline: +0.3% Memory: ✅ 37.391MB (SLO: <39.000MB -4.1%) vs baseline: +4.6% ✅ import_one_cacheTime: ✅ 6.291µs (SLO: <10.000µs 📉 -37.1%) vs baseline: +0.4% Memory: ✅ 36.959MB (SLO: <38.500MB -4.0%) vs baseline: +3.7% ✅ import_one_stdlibTime: ✅ 18.879µs (SLO: <20.000µs -5.6%) vs baseline: +1.3% Memory: ✅ 36.942MB (SLO: <38.500MB -4.0%) vs baseline: +3.8% ✅ import_one_stdlib_cacheTime: ✅ 6.297µs (SLO: <10.000µs 📉 -37.0%) vs baseline: -0.5% Memory: ✅ 37.584MB (SLO: <38.500MB -2.4%) vs baseline: +6.6% ✅ import_one_unknownTime: ✅ 45.358µs (SLO: <50.000µs -9.3%) vs baseline: -0.3% Memory: ✅ 37.020MB (SLO: <38.500MB -3.8%) vs baseline: +3.7% ✅ import_one_unknown_cacheTime: ✅ 6.286µs (SLO: <10.000µs 📉 -37.1%) vs baseline: -0.4% Memory: ✅ 37.564MB (SLO: <38.500MB -2.4%) vs baseline: +6.8% 
 | 
Description
LLMObs and CIVisibility are currently using evp_proxy, and in the coming days, the new OpenFeature functionality will also need the proxy.
This PR consolidates in the
ddtrace/internal/evp_proxynamespace the constants common to this proxy.Next steps: