Skip to content

perf(profiling): use echion with memcpy #15030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Draft

perf(profiling): use echion with memcpy #15030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ddtrace/internal/datadog/profiling/stack_v2/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ endif()

# Add echion
set(ECHION_COMMIT
"1b02a8fcccaa4b748b494f3c3177b78be6503967" # https://github.com/P403n1x87/echion/commit/1b02a8fcccaa4b748b494f3c3177b78be6503967
"d74cf936d509f311bb418b1384281fe03c4f4b8b" # https://github.com/kowalskithomas/echion/commit/d74cf936d509f311bb418b1384281fe03c4f4b8b
CACHE STRING "Commit hash of echion to use")
FetchContent_Declare(
echion
GIT_REPOSITORY "https://github.com/P403n1x87/echion.git"
GIT_REPOSITORY "https://github.com/kowalskithomas/echion.git"
GIT_TAG ${ECHION_COMMIT})
FetchContent_GetProperties(echion)

Expand All @@ -62,7 +62,7 @@ if(NOT echion_POPULATED)
endif()

# Specify the target C-extension that we want to build
add_library(${EXTENSION_NAME} SHARED ${echion_SOURCE_DIR}/echion/frame.cc ${echion_SOURCE_DIR}/echion/render.cc
add_library(${EXTENSION_NAME} SHARED ${echion_SOURCE_DIR}/echion/frame.cc ${echion_SOURCE_DIR}/echion/render.cc ${echion_SOURCE_DIR}/echion/danger.cc
src/sampler.cpp src/stack_renderer.cpp src/stack_v2.cpp src/thread_span_links.cpp)

# Add common config
Expand Down
4 changes: 4 additions & 0 deletions releasenotes/notes/profiling-update-echion-1cb85860b04f891d.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
upgrade:
- |
profiling: this updates echion (the python stack sampler) to the latest version, which introduces opt-in support
for a faster memory copyfunction.
Loading