Skip to content

chore(logger): disable native logging by default #15005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −3
Open

chore(logger): disable native logging by default #15005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e04295
chore(logger): disable native logging by default
VianneyRuhlmann Oct 23, 2025
99bf773
Merge branch 'main' into vianney/disable-native-logging-by-default
VianneyRuhlmann Oct 30, 2025
542214b
test(logger): update logger test
VianneyRuhlmann Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ddtrace/_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,9 @@ def _configure_ddtrace_native_logger():
from .settings._config import config

if config._trace_writer_native:
backend = get_config("_DD_NATIVE_LOGGING_BACKEND", "file", report_telemetry=True)
backend = get_config("_DD_NATIVE_LOGGING_BACKEND", report_telemetry=True)
if not backend:
return
kwargs = {"output": backend}
if backend == "file":
kwargs["path"] = get_config("_DD_NATIVE_LOGGING_FILE_PATH", "native.log", report_telemetry=True)
Expand Down
8 changes: 6 additions & 2 deletions tests/tracer/test_native_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def test_logger_configure(output, path, files, max_bytes):
cases = [(config, msg, LEVELS.index(msg) >= LEVELS.index(config)) for config in LEVELS for msg in LEVELS]


@pytest.mark.parametrize("backend", ["stdout", "stderr", "file"])
@pytest.mark.parametrize("backend", ["", "stdout", "stderr", "file"])
@pytest.mark.parametrize("configured_level, message_level, should_log", cases)
def test_logger_subprocess(
backend, configured_level, message_level, should_log, tmp_path, ddtrace_run_python_code_in_subprocess
Expand All @@ -93,7 +93,11 @@ def test_logger_subprocess(
out, err, status, _ = ddtrace_run_python_code_in_subprocess(code, env=env)

assert status == 0
if backend == "stdout":
if backend == "":
assert out == b""
assert err == b""
assert not log_path.exists()
elif backend == "stdout":
found = message in out.decode("utf8")
assert err == b""
assert found == should_log
Expand Down
Loading