Skip to content

chore(profiling): use default optimization flags instead of -Os #14392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
+4 −5
Draft

chore(profiling): use default optimization flags instead of -Os #14392

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
32ad1c1
chore(profiling): use default optimization flags instead of -Os
taegyunkim Aug 21, 2025
9edd366
Merge branch 'main' into taegyunkim/use-opt-flags
taegyunkim Aug 22, 2025
789be77
Merge branch 'main' into taegyunkim/use-opt-flags
taegyunkim Aug 26, 2025
8a0fcb0
Merge branch 'main' into taegyunkim/use-opt-flags
taegyunkim Aug 28, 2025
6240528
use gdb2
taegyunkim Aug 28, 2025
12c4183
Fix target_compile_options for non-macOS builds
taegyunkim Aug 28, 2025
c614280
Merge branch 'main' into taegyunkim/use-opt-flags
taegyunkim Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions ddtrace/internal/datadog/profiling/cmake/AnalysisFunc.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ function(add_ddup_config target)
# Common compile options
target_compile_options(
${target}
PRIVATE "$<$<CONFIG:Release>:-Os>"
-ffunction-sections
PRIVATE -ffunction-sections
-Wall
-Werror
-Wextra
Expand All @@ -19,11 +18,11 @@ function(add_ddup_config target)

if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
# macOS-specific options
target_compile_options(${target} PRIVATE "$<$<CONFIG:Debug>:-Og;-g>" "$<$<CONFIG:RelWithDebInfo>:-Os;-g>")
target_compile_options(${target} PRIVATE "$<$<CONFIG:Debug>:-g>" "$<$<CONFIG:RelWithDebInfo>:-g>")
else()
# Non-macOS (e.g., Linux) options
target_compile_options(${target} PRIVATE "$<$<CONFIG:Debug>:-Og;-ggdb3>"
"$<$<CONFIG:RelWithDebInfo>:-Os;-ggdb3>" -fno-semantic-interposition)
target_compile_options(${target} PRIVATE "$<$<CONFIG:Debug>:-ggdb3>" "$<$<CONFIG:RelWithDebInfo>:-ggdb2>"
-fno-semantic-interposition)
endif()

# Common link options
Expand Down
Loading