-
Notifications
You must be signed in to change notification settings - Fork 457
fix(profiling): support for greenlets [backport 3.10] #14029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We improve the error handling around greenlet tracking to catch any unexpected errors and prevent the target application from failing to spawn greenlets. One observed case of failure was due to the string table failing to resolve a string (the greenlet name in this case) into a cache key. We expect this kind of errors to be rare, but we add logic to handle them should they occur. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Taegyun Kim <[email protected]> (cherry picked from commit 9fec84d)
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 289 ± 5 ms. The average import time from base is: 286 ± 5 ms. The import time difference between this PR and base is: 2.7 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
This pull request has been automatically closed after a period of inactivity. |
Pull request was closed
Backport 9fec84d from #14011 to 3.10.
We improve the error handling around greenlet tracking to catch any unexpected errors and prevent the target application from failing to spawn greenlets. One observed case of failure was due to the string table failing to resolve a string (the greenlet name in this case) into a cache key. We expect this kind of errors to be rare, but we add logic to handle them should they occur.
Checklist
Reviewer Checklist