Skip to content

Conversation

alyshawang
Copy link
Contributor

@alyshawang alyshawang commented Jun 2, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@alyshawang alyshawang requested a review from a team as a code owner June 2, 2025 15:21
Copy link
Contributor

github-actions bot commented Jun 2, 2025

CODEOWNERS have been resolved as:

tests/profiling_v2/collector/test_stack_asyncio.py                      @DataDog/profiling-python
tests/profiling_v2/collector/test_threading.py                          @DataDog/profiling-python

@alyshawang alyshawang changed the title Changes to tests to pass when building fix: changes to tests to pass when building Jun 2, 2025
Copy link
Contributor

github-actions bot commented Jun 2, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 237 ± 3 ms.

The average import time from base is: 239 ± 3 ms.

The import time difference between this PR and base is: -2.7 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.087 ms (0.88%)
ddtrace.bootstrap.sitecustomize 1.412 ms (0.60%)
ddtrace.bootstrap.preload 1.412 ms (0.60%)
ddtrace.internal.remoteconfig.client 0.664 ms (0.28%)
ddtrace 0.675 ms (0.29%)
ddtrace.internal._unpatched 0.024 ms (0.01%)

@alyshawang alyshawang changed the title fix: changes to tests to pass when building chore(profiling): changes to tests to pass when building Jun 2, 2025
@nsrip-dd nsrip-dd added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 2, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jun 2, 2025

Benchmarks

Benchmark execution time: 2025-06-02 20:21:39

Comparing candidate commit c4e55a8 in PR branch alysha.wang/test_changes with baseline commit 870e62f in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 503 metrics, 3 unstable metrics.

scenario:iastaspects-format_map_aspect

  • 🟥 execution_time [+496.041ns; +545.105ns] or [+15.608%; +17.152%]

scenario:iastaspects-ljust_aspect

  • 🟥 execution_time [+1.364µs; +1.499µs] or [+10.554%; +11.598%]

@taegyunkim taegyunkim added the Profiling Continous Profling label Jun 2, 2025
@taegyunkim taegyunkim changed the title chore(profiling): changes to tests to pass when building chore(profiling): address test failures when run on macOS Jun 2, 2025
@taegyunkim taegyunkim enabled auto-merge (squash) June 2, 2025 20:57
@taegyunkim taegyunkim merged commit 78580b8 into main Jun 2, 2025
312 of 313 checks passed
@taegyunkim taegyunkim deleted the alysha.wang/test_changes branch June 2, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants