Skip to content

chore(litellm): skip flaky litellm tests #13561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025

Conversation

ncybul
Copy link
Contributor

@ncybul ncybul commented Jun 2, 2025

The test_completion_openai_enabled test is flaky in CI due to some issues patching Open AI to be used within the LiteLLM library. This PR uses @pytest.mark.skip to avoid running these tests in CI.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@ncybul ncybul changed the title skip flaky litellm tests chore(litellm): skip flaky litellm tests Jun 2, 2025
Copy link
Contributor

github-actions bot commented Jun 2, 2025

CODEOWNERS have been resolved as:

tests/contrib/litellm/test_litellm_llmobs.py                            @DataDog/apm-core-python @DataDog/apm-idm-python

@ncybul ncybul added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 2, 2025
Copy link
Contributor

github-actions bot commented Jun 2, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 240 ± 10 ms.

The average import time from base is: 238 ± 3 ms.

The import time difference between this PR and base is: 0.4 ± 0.4 ms.

The difference is not statistically significant (z = 0.96).

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.256 ms (0.53%)
ddtrace 0.648 ms (0.27%)
ddtrace.bootstrap.sitecustomize 0.607 ms (0.25%)
ddtrace.bootstrap.preload 0.607 ms (0.25%)
ddtrace.internal.remoteconfig.client 0.607 ms (0.25%)

@pr-commenter
Copy link

pr-commenter bot commented Jun 2, 2025

Benchmarks

Benchmark execution time: 2025-06-02 17:44:39

Comparing candidate commit 23908e6 in PR branch nicole-cybul/skip-litellm-flaky-tests with baseline commit 736220e in branch main.

Found 0 performance improvements and 6 performance regressions! Performance is the same for 461 metrics, 9 unstable metrics.

scenario:iastaspects-lower_aspect

  • 🟥 execution_time [+175.198ns; +216.619ns] or [+7.751%; +9.584%]

scenario:iastaspects-lstrip_aspect

  • 🟥 execution_time [+1.251µs; +1.493µs] or [+9.708%; +11.588%]

scenario:iastaspects-replace_aspect

  • 🟥 execution_time [+537.475ns; +607.494ns] or [+11.444%; +12.935%]

scenario:iastaspects-rstrip_aspect

  • 🟥 execution_time [+1.352µs; +1.533µs] or [+10.574%; +11.990%]

scenario:iastaspects-swapcase_aspect

  • 🟥 execution_time [+188.768ns; +227.933ns] or [+7.645%; +9.231%]

scenario:iastaspectsospath-ospathjoin_aspect

  • 🟥 execution_time [+575.620ns; +793.802ns] or [+9.370%; +12.922%]

@ncybul ncybul marked this pull request as ready for review June 2, 2025 16:56
@ncybul ncybul requested review from a team as code owners June 2, 2025 16:56
@ncybul ncybul requested review from juanjux and wconti27 June 2, 2025 16:56
@brettlangdon brettlangdon enabled auto-merge (squash) June 2, 2025 17:06
@brettlangdon brettlangdon merged commit 94a030b into main Jun 2, 2025
423 of 425 checks passed
@brettlangdon brettlangdon deleted the nicole-cybul/skip-litellm-flaky-tests branch June 2, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants