-
Notifications
You must be signed in to change notification settings - Fork 455
fix(sampling): validate_sampling_decision giving log warns on supported mechanisms #13554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 245 ± 3 ms. The average import time from base is: 247 ± 2 ms. The import time difference between this PR and base is: -1.6 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
This reverts commit 77763aa.
releasenotes/notes/fix-validate-sampling-decision-logging-561e2ef1c0156b5e.yaml
Outdated
Show resolved
Hide resolved
…2ef1c0156b5e.yaml Co-authored-by: Emmett Butler <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.21 2.21
# Navigate to the new working tree
cd .worktrees/backport-2.21
# Create a new branch
git switch --create backport-13554-to-2.21
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 733711e80245610dfd3af221fb9b3f32b6a3ff97
# Push it to GitHub
git push --set-upstream origin backport-13554-to-2.21
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.21 Then, create a pull request where the |
…ed mechanisms (#13554) #13516 https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/961877338#L460 =========================== short test summary info ============================ FAILED tests/integration/test_sampling.py::test_supported_sampling_mechanism - AssertionError: DATA_JOBS_MONITORING returned {'_dd.propagation_error': 'decoding_error'} assert {'_dd.propagation_error': 'decoding_error'} != {'_dd.propagation_error': 'decoding_error'} ====== 1 failed, 104 passed, 28 skipped, 6 xpassed, 14 warnings in 26.31s ====== Test failed with exit code 1 - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Emmett Butler <[email protected]> (cherry picked from commit 733711e)
…ted mechanisms (backport 2.21) (#13579) Attempt to backport 2.2x for #13554 (comment) ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Benson Quach <[email protected]> Co-authored-by: Emmett Butler <[email protected]> Co-authored-by: Brett Langdon <[email protected]>
#13516
https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/961877338#L460
=========================== short test summary info ============================
FAILED tests/integration/test_sampling.py::test_supported_sampling_mechanism - AssertionError: DATA_JOBS_MONITORING returned {'_dd.propagation_error': 'decoding_error'}
assert {'_dd.propagation_error': 'decoding_error'} != {'_dd.propagation_error': 'decoding_error'}
====== 1 failed, 104 passed, 28 skipped, 6 xpassed, 14 warnings in 26.31s ======
Test failed with exit code 1
Checklist
Reviewer Checklist