Skip to content

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented May 30, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Signed-off-by: Juanjo Alvarez <[email protected]>
@juanjux juanjux requested review from a team as code owners May 30, 2025 13:47
@juanjux juanjux self-assigned this May 30, 2025
Copy link
Contributor

github-actions bot commented May 30, 2025

CODEOWNERS have been resolved as:

.riot/requirements/6780b6b.txt                                          @DataDog/apm-python
.riot/requirements/73136d3.txt                                          @DataDog/apm-python
.riot/requirements/ba34840.txt                                          @DataDog/apm-python
hatch.toml                                                              @DataDog/python-guild
lib-injection/sources/min_compatible_versions.csv                       @DataDog/apm-core-python
min_compatible_versions.csv                                             @DataDog/apm-core-python
riotfile.py                                                             @DataDog/apm-python
tests/appsec/suitespec.yml                                              @DataDog/asm-python

@juanjux juanjux added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring and removed backport 2.21 labels May 30, 2025
Copy link
Contributor

github-actions bot commented May 30, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 248 ± 4 ms.

The average import time from base is: 244 ± 4 ms.

The import time difference between this PR and base is: 3.4 ± 0.2 ms.

Import time breakdown

The following import paths have grown:

ddtrace.auto 0.862 ms (0.35%)
ddtrace 0.561 ms (0.23%)
ddtrace._logger 0.284 ms (0.11%)
ddtrace.internal.telemetry 0.284 ms (0.11%)
ddtrace.settings._agent 0.147 ms (0.06%)
ddtrace.settings 0.111 ms (0.04%)
ddtrace.settings.http 0.111 ms (0.04%)
ddtrace.internal.utils.http 0.111 ms (0.04%)
email.encoders 0.111 ms (0.04%)
base64 0.111 ms (0.04%)
socket 0.036 ms (0.01%)
_socket 0.036 ms (0.01%)
ddtrace.internal.telemetry.writer 0.137 ms (0.06%)
http.client 0.137 ms (0.06%)
email.parser 0.137 ms (0.06%)
email.feedparser 0.137 ms (0.06%)
email._policybase 0.137 ms (0.06%)
email.utils 0.137 ms (0.06%)
datetime 0.137 ms (0.06%)
_datetime 0.137 ms (0.06%)
ddtrace.settings._config 0.179 ms (0.07%)
ddtrace.internal._file_queue 0.179 ms (0.07%)
secrets 0.179 ms (0.07%)
hmac 0.179 ms (0.07%)
_hashlib 0.179 ms (0.07%)
ddtrace.trace 0.098 ms (0.04%)
ddtrace._trace.filters 0.043 ms (0.02%)
ddtrace._trace.processor 0.043 ms (0.02%)
ddtrace.internal.dogstatsd 0.043 ms (0.02%)
ddtrace.vendor.dogstatsd 0.043 ms (0.02%)
ddtrace.vendor.dogstatsd.base 0.043 ms (0.02%)
ddtrace.bootstrap.sitecustomize 0.301 ms (0.12%)
ddtrace.bootstrap.preload 0.301 ms (0.12%)
multiprocessing.sharedctypes 0.129 ms (0.05%)
multiprocessing.heap 0.129 ms (0.05%)
mmap 0.129 ms (0.05%)
ddtrace.internal.products 0.126 ms (0.05%)
importlib.metadata 0.126 ms (0.05%)
importlib.abc 0.126 ms (0.05%)
importlib.resources 0.126 ms (0.05%)
ddtrace.internal.symbol_db.remoteconfig 0.046 ms (0.02%)

The following import paths have shrunk:

ddtrace.auto 1.201 ms (0.49%)
ddtrace 0.665 ms (0.27%)
ddtrace.internal._unpatched 0.020 ms (0.01%)
ddtrace.bootstrap.sitecustomize 0.536 ms (0.22%)
ddtrace.bootstrap.preload 0.536 ms (0.22%)
ddtrace.internal.remoteconfig.client 0.536 ms (0.22%)

@pr-commenter
Copy link

pr-commenter bot commented May 30, 2025

Benchmarks

Benchmark execution time: 2025-06-04 09:55:36

Comparing candidate commit 8fac233 in PR branch juanjux/iast_leak_testing_to_riot with baseline commit c92af09 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 505 metrics, 3 unstable metrics.

@juanjux juanjux enabled auto-merge (squash) June 4, 2025 08:54
juanjux and others added 2 commits June 4, 2025 10:59
Co-authored-by: Alberto Vara <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
@juanjux juanjux merged commit 7585239 into main Jun 4, 2025
737 of 738 checks passed
@juanjux juanjux deleted the juanjux/iast_leak_testing_to_riot branch June 4, 2025 11:11
juanjux added a commit that referenced this pull request Jun 4, 2025
brettlangdon pushed a commit that referenced this pull request Jun 5, 2025
Reverts #13544

Looks like it could randonmly be slower on riot for some reason.

## Checklist
- [X] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants