-
Notifications
You must be signed in to change notification settings - Fork 455
chore(iast): reduce ssrf false positives #13530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 242 ± 5 ms. The average import time from base is: 243 ± 3 ms. The import time difference between this PR and base is: -0.9 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-06-02 07:57:13 Comparing candidate commit b23335c in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 499 metrics, 5 unstable metrics. scenario:iastaspects-swapcase_aspect
scenario:iastaspectsospath-ospathnormcase_aspect
scenario:iastaspectsospath-ospathsplitdrive_aspect
scenario:iastaspectsospath-ospathsplitext_aspect
|
This PR improves the accuracy of SSRF (Server-Side Request Forgery) vulnerability detection in the IAST module by reducing false positives, particularly when dealing with URL fragments.
Key Changes
Motivation
URL fragments (parts after #) are client-side only and not sent to the server, making them irrelevant for SSRF vulnerabilities. The current implementation was generating false positives when tainted data appeared only in URL fragments, leading to unnecessary alerts.
Testing Strategy
tests/appsec/iast/taint_sinks/test_ssrf.py
Checklist
Reviewer Checklist