-
Notifications
You must be signed in to change notification settings - Fork 439
chore(telemetry): integration error telemetry logs are sent through a function call #13510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 234 ± 3 ms. The average import time from base is: 247 ± 4 ms. The import time difference between this PR and base is: -13.6 ± 0.2 ms. Import time breakdownThe following import paths have disappeared:
|
BenchmarksBenchmark execution time: 2025-05-28 09:30:43 Comparing candidate commit 85ab73a in PR branch Found 2 performance improvements and 10 performance regressions! Performance is the same for 503 metrics, 5 unstable metrics. scenario:iast_aspects-ljust_aspect
scenario:iast_aspects-lower_aspect
scenario:iast_aspects-lstrip_aspect
scenario:iast_aspects-ospathbasename_aspect
scenario:iast_aspects-ospathnormcase_aspect
scenario:iast_aspects-ospathsplit_aspect
scenario:iast_aspects-replace_aspect
scenario:iast_aspects-rstrip_aspect
scenario:iast_aspects-strip_aspect
scenario:iast_aspects-upper_aspect
scenario:iastdjangostartup-appsec
scenario:iastdjangostartup-tracer
|
698887b
to
4c81fcd
Compare
4c81fcd
to
74378d8
Compare
Motivation
Integration related error telemetry logs were added in #11732. However, it is using a LogHandler. After a discussion in a previous guild meeting, it appeared that we don't want to use LogHandler as it could have an impact on the customer logger.
In addition, to be able to report integration error logs to telemetry you needed to enable debug logs (as in the integration the errors are logged using debug level). However, telemetry activation should be tied to the log level.
What does this PR do ?
<REDACTED>
for every lines we are redacting (before we were only adding one<REDACTED>
for the redaction of two lines)What this PR doesn't do
Checklist
Reviewer Checklist