-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add integration registry #13051
base: main
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 230 ± 3 ms. The average import time from base is: 233 ± 2 ms. The import time difference between this PR and base is: -2.7 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
name = entry.get("integration_name", "UNKNOWN_ENTRY") | ||
is_external = entry.get("is_external_package") | ||
|
||
if is_external is True: # Only check external packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This PR adds a registry for integrations, that for a start contains the name of the integration and the package dependency name. The PR also adds a whitelist for directories within
ddtrace/contrib/internal
that do not have an associated package, including internal python packages, the ddtrace api, and abstracted integrations like dbapi. The PR also adds a test to ensure that new integration directories cannot be added without being added to the registry or whitelist.Checklist
Reviewer Checklist