Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test optimization] Configuration parameter to disable git unshallow #5291

Merged
merged 7 commits into from
Feb 20, 2025

Conversation

Mariovido
Copy link
Contributor

@Mariovido Mariovido commented Feb 18, 2025

What does this PR do?

This PR introduces a parameter to control the git unshallow process when retrieving git metadata.

Motivation

We aim to offer the option to disable it, helping users reduce costs.

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented Feb 18, 2025

Overall package size

Self size: 8.76 MB
Deduped: 94.96 MB
No deduping: 95.48 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.81%. Comparing base (77abd1e) to head (7d42f82).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5291      +/-   ##
==========================================
- Coverage   80.91%   79.81%   -1.11%     
==========================================
  Files         488      478      -10     
  Lines       21817    21351     -466     
==========================================
- Hits        17654    17042     -612     
- Misses       4163     4309     +146     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 18, 2025

Datadog Report

Branch report: mario.vidal/git_unshallow
Commit report: 29f2173
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 667 Passed, 0 Skipped, 11m 17.42s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 18, 2025

Benchmarks

Benchmark execution time: 2025-02-20 11:40:39

Comparing candidate commit 7d42f82 in PR branch mario.vidal/git_unshallow with baseline commit 77abd1e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 917 metrics, 16 unstable metrics.

@@ -1146,7 +1147,8 @@ class Config {
DD_AGENTLESS_LOG_SUBMISSION_ENABLED,
DD_TEST_DYNAMIC_INSTRUMENTATION_ENABLED,
DD_TEST_MANAGEMENT_ENABLED,
DD_TEST_MANAGEMENT_ATTEMPT_TO_FIX_RETRIES
DD_TEST_MANAGEMENT_ATTEMPT_TO_FIX_RETRIES,
DD_TEST_UNSHALLOW_ENABLED
Copy link
Collaborator

@juan-fernandez juan-fernandez Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make this DD_CIVISIBILITY_GIT_UNSHALLOW_ENABLED so as to align with Java.

Also: let me think if we need to go through the config changes. Maybe we can check process.env.DD_CIVISIBILITY_GIT_UNSHALLOW_ENABLED directly in the git code, as I see no advantage in adding it to the config

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed!

Copy link
Collaborator

@juan-fernandez juan-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!

@juan-fernandez
Copy link
Collaborator

you can mark the PR as ready for review whenever you want

@Mariovido Mariovido marked this pull request as ready for review February 20, 2025 11:37
@Mariovido Mariovido requested a review from a team as a code owner February 20, 2025 11:37
@Mariovido Mariovido merged commit 23abc09 into master Feb 20, 2025
395 checks passed
@Mariovido Mariovido deleted the mario.vidal/git_unshallow branch February 20, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants