Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test optimization] Change failed test replay to opt out rather than opt in #5283

Merged

Conversation

juan-fernandez
Copy link
Collaborator

What does this PR do?

  • Change env var for activating failed test replay from DD_TEST_DYNAMIC_INSTRUMENTATION_ENABLED to DD_TEST_FAILED_TEST_REPLAY_ENABLED.
  • Change default value from false to true.

Motivation

We want to consider the feature GA.

Plugin Checklist

Just make sure that the tests still pass

Copy link

github-actions bot commented Feb 17, 2025

Overall package size

Self size: 8.75 MB
Deduped: 94.95 MB
No deduping: 95.47 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (14a3795) to head (86e5c78).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5283      +/-   ##
==========================================
+ Coverage   80.87%   80.91%   +0.04%     
==========================================
  Files         484      488       +4     
  Lines       21783    21817      +34     
==========================================
+ Hits        17616    17654      +38     
+ Misses       4167     4163       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Feb 17, 2025

Benchmarks

Benchmark execution time: 2025-02-18 14:27:58

Comparing candidate commit 86e5c78 in PR branch juan-fernandez/flip-default-value-failed-test-replay with baseline commit 14a3795 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 909 metrics, 23 unstable metrics.

scenario:plugin-graphql-with-async-hooks-18

  • 🟥 max_rss_usage [+88.687MB; +99.517MB] or [+16.749%; +18.794%]

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 17, 2025

Datadog Report

Branch report: juan-fernandez/flip-default-value-failed-test-replay
Commit report: c0acfe6
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 666 Passed, 0 Skipped, 12m 44.57s Total Time

@juan-fernandez juan-fernandez marked this pull request as ready for review February 17, 2025 15:56
@juan-fernandez juan-fernandez requested review from a team as code owners February 17, 2025 15:56
@juan-fernandez juan-fernandez changed the title [test optimization] Change auto test replay to opt out rather than opt in [test optimization] Change failed test replay to opt out rather than opt in Feb 18, 2025
@juan-fernandez juan-fernandez merged commit e6ea5fd into master Feb 18, 2025
360 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/flip-default-value-failed-test-replay branch February 18, 2025 14:34
@watson watson mentioned this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants