downgrade eslint to support node 18

[rochdev]

What does this PR do?

Downgrade eslint to support Node 18

Motivation

Linting otherwise doesn't work on some supported versions which makes working on them a pain.

[github-actions]

Overall package size

Self size: 8.54 MB
Deduped: 94.94 MB
No deduping: 95.45 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.07%. Comparing base (fd61c8c) to head (5090af8).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5179   +/-   ##
=======================================
  Coverage   81.06%   81.07%           
=======================================
  Files         477      479    +2     
  Lines       21327    21337   +10     
=======================================
+ Hits        17288    17298   +10     
  Misses       4039     4039           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[datadog-datadog-prod-us1]

Datadog Report

Branch report: eslint-8
Commit report: fa5997b
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 616 Passed, 0 Skipped, 14m 48.11s Total Time

[pr-commenter]

Benchmarks

Benchmark execution time: 2025-01-30 16:27:17

Comparing candidate commit 5090af8 in PR branch eslint-8 with baseline commit fd61c8c in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 912 metrics, 20 unstable metrics.

scenario:plugin-graphql-with-depth-on-max-18

• 🟩 max_rss_usage [-57.742MB; -49.226MB] or [-5.940%; -5.064%]

[watson]

As far as I understand ESLint v9 works on the following Node.js releases: ^18.18.0, ^20.9.0, or >=21.1.0. I assume you're primarily making this change to allow running ESLint on for example Node.js 18.0.0? If so, what's the use-case for doing that?